signedMoney/unsignedMoney are not functions

Author: PowerKiKi

projects/natural/src/lib/classes/validators.spec.ts

@@ -329,7 +329,7 @@ describe('money', () => {
 
 describe('signedMoney', () => {
     it('should allow negative and positive amounts within the human limit', () => {
-        const validator = signedMoney();
+        const validator = signedMoney;
         validate(validator, true, '-5000000');
         validate(validator, true, '5000000');
         validate(validator, false, '-5000000.01');
@@ -339,7 +339,7 @@ describe('signedMoney', () => {
 
 describe('unsignedMoney', () => {
     it('should only allow positive amounts within the human limit', () => {
-        const validator = unsignedMoney();
+        const validator = unsignedMoney;
         validate(validator, true, '0');
         validate(validator, true, '5000000');
         validate(validator, false, '-0.01');

projects/natural/src/lib/classes/validators.ts

@@ -240,7 +240,7 @@ const twoDecimals = decimal(2);
  *
  * A range is always required, because unbounded financial inputs allow gross typos (eg. an extra
  * digit) to slip through and cause data corruption, so callers must always think about a sensible
- * limit. For most cases, prefer the ready-made `signedMoney()` or `unsignedMoney()` helpers instead
+ * limit. For most cases, prefer the ready-made `signedMoney` or `unsignedMoney` helpers instead
  * of calling this directly.
  */
 export function money(min: number, max: number): ValidatorFn {
@@ -270,17 +270,13 @@ const maxMoney = 5_000_000;
  * Validate a signed amount of money (can be negative), suitable for a value stored in a database
  * column of type `SIGNED INT`, such as a balance.
  */
-export function signedMoney(): ValidatorFn {
-    return money(-maxMoney, maxMoney);
-}
+export const signedMoney = money(-maxMoney, maxMoney);
 
 /**
  * Validate an unsigned amount of money (cannot be negative), suitable for a value stored in a
  * database column of type `UNSIGNED INT`, such as a price.
  */
-export function unsignedMoney(): ValidatorFn {
-    return money(0, maxMoney);
-}
+export const unsignedMoney = money(0, maxMoney);
 
 /**
  * Validate that the number is strictly greater than given one.

src/app/other/other.component.html

@@ -66,13 +66,13 @@ <h1>Money validators</h1>
         </mat-form-field>
 
         <mat-form-field>
-            <mat-label>signedMoney()</mat-label>
+            <mat-label>signedMoney</mat-label>
             <input matInput [formControl]="signedMoneyControl" />
             <mat-error>{{ signedMoneyControl.errors | errorMessage }}</mat-error>
         </mat-form-field>
 
         <mat-form-field>
-            <mat-label>unsignedMoney()</mat-label>
+            <mat-label>unsignedMoney</mat-label>
             <input matInput [formControl]="unsignedMoneyControl" />
             <mat-error>{{ unsignedMoneyControl.errors | errorMessage }}</mat-error>
         </mat-form-field>

src/app/other/other.component.ts

@@ -267,8 +267,8 @@ export class OtherComponent implements OnInit {
      * Money validators
      */
     public readonly moneyControl = new FormControl('', [money(-1000, 1000)]);
-    public readonly signedMoneyControl = new FormControl('', [signedMoney()]);
-    public readonly unsignedMoneyControl = new FormControl('', [unsignedMoney()]);
+    public readonly signedMoneyControl = new FormControl('', [signedMoney]);
+    public readonly unsignedMoneyControl = new FormControl('', [unsignedMoney]);
 
     public ngOnInit(): void {
         this.httpPrefixControl.valueChanges.subscribe(value => {