this is mild piracy
|
Base.string(v::Vector{ParsedHTMLString}) = join(v) |
and this one is super piracy
|
Base.string(v::Vector{AbstractString}) = join(v) |
this is going to have all the normal drawbacks of piracy (increased risk of invalidations / recompilation, surprising behavior changes depending on the loaded environment making code harder to reason about) and in this case also comes with correctness issues since this is changing the behavior of Base.string(::Vector{AbstractString}). I highly recommend deleting both of these methods.
this is mild piracy
Genie.jl/src/renderers/Html.jl
Line 75 in 910d24e
and this one is super piracy
Genie.jl/src/renderers/Html.jl
Line 107 in 910d24e
this is going to have all the normal drawbacks of piracy (increased risk of invalidations / recompilation, surprising behavior changes depending on the loaded environment making code harder to reason about) and in this case also comes with correctness issues since this is changing the behavior of
Base.string(::Vector{AbstractString}). I highly recommend deleting both of these methods.