Skip to content

Commit fe90ccf

Browse files
Merge pull request #51 from Giveth/revert-social-values
reverting social values
2 parents 399e2e4 + 06c0b6d commit fe90ccf

11 files changed

Lines changed: 36 additions & 36 deletions

File tree

.env.example

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ TWITTER_MAX_RETRIES=3
9595
TWITTER_BASE_RETRY_DELAY_MS=5000
9696

9797
# Twitter Posts Configuration
98-
TWITTER_POSTS_LOOKBACK_DAYS=60 # Days to look back for posts
99-
TWITTER_MAX_TWEETS_TO_COLLECT=50 # Maximum tweets to collect and store
98+
TWITTER_POSTS_LOOKBACK_DAYS=30 # Days to look back for posts
99+
TWITTER_MAX_TWEETS_TO_COLLECT=15 # Maximum tweets to collect and store
100100

101101
# ===========================================
102102
# FARCASTER CONFIGURATION (FREE - NO API KEYS REQUIRED)
@@ -106,11 +106,11 @@ TWITTER_MAX_TWEETS_TO_COLLECT=50 # Maximum tweets to collect and store
106106
FARCASTER_MIN_DELAY_MS=2000 # 2 seconds minimum delay
107107
FARCASTER_MAX_DELAY_MS=3000 # 3 seconds maximum delay
108108
FARCASTER_MAX_RETRIES=3 # Maximum retry attempts
109-
FARCASTER_POSTS_LOOKBACK_DAYS=60 # Days to look back for posts
110-
FARCASTER_MAX_POSTS_PER_PROJECT=50 # Maximum posts per project
109+
FARCASTER_POSTS_LOOKBACK_DAYS=30 # Days to look back for posts
110+
FARCASTER_MAX_POSTS_PER_PROJECT=15 # Maximum posts per project
111111
FARCASTER_FID_CACHE_TTL=86400 # FID cache TTL (24 hours)
112112
FARCASTER_CASTS_CACHE_TTL=3600 # Casts cache TTL (1 hour)
113-
FARCASTER_BATCH_SIZE=30 # Number of casts to fetch before filtering
113+
FARCASTER_BATCH_SIZE=15 # Number of casts to fetch before filtering
114114

115115
# Farcaster API endpoints (FREE - no API keys needed)
116116
FARCASTER_FNAME_REGISTRY_URL=https://fnames.farcaster.xyz # FName Registry for FID lookup
@@ -136,12 +136,12 @@ JOB_MAX_RETRIES=3 # Retry attempts
136136
# ===========================================
137137

138138
# Social media storage configuration
139-
SOCIAL_POST_MAX_COUNT=50 # Max social posts to keep per project
139+
SOCIAL_POST_MAX_COUNT=15 # Max social posts to keep per project
140140
SOCIAL_POST_MAX_AGE_DAYS=90 # Days to retain social posts
141141

142142
# Social media frequency scoring configuration
143-
SCORING_SOCIAL_FREQUENCY_DAYS=60 # Days to consider for frequency calculation
144-
SCORING_MIN_POSTS_FOR_FULL_FREQUENCY=45 # Min posts for full frequency score
143+
SCORING_SOCIAL_FREQUENCY_DAYS=30 # Days to consider for frequency calculation
144+
SCORING_MIN_POSTS_FOR_FULL_FREQUENCY=10 # Min posts for full frequency score
145145

146146
# ===========================================
147147
# LLM INTEGRATION

CLAUDE.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ TWITTER_MAX_RETRIES=3
9292
TWITTER_BASE_RETRY_DELAY_MS=5000
9393

9494
# Twitter Fetch Limits
95-
TWITTER_POSTS_LOOKBACK_DAYS=60 # Days to look back for posts
96-
TWITTER_MAX_TWEETS_TO_COLLECT=50 # Maximum tweets to collect and store
95+
TWITTER_POSTS_LOOKBACK_DAYS=30 # Days to look back for posts
96+
TWITTER_MAX_TWEETS_TO_COLLECT=15 # Maximum tweets to collect and store
9797

9898
# Farcaster Integration (FREE - No API Keys Required)
9999
# Uses FName Registry and Warpcast APIs - completely free
@@ -107,12 +107,12 @@ GIVETH_API_BASE_URL=https://api.giveth.io
107107
GIVETH_API_KEY=your_giveth_key
108108

109109
# Social Media Storage Configuration
110-
SOCIAL_POST_MAX_COUNT=50 # Max social posts to keep per project (also used as default limit for admin API viewing)
110+
SOCIAL_POST_MAX_COUNT=15 # Max social posts to keep per project (also used as default limit for admin API viewing)
111111
SOCIAL_POST_MAX_AGE_DAYS=90 # Days to retain social posts
112112

113113
# Social media frequency scoring configuration
114-
SCORING_SOCIAL_FREQUENCY_DAYS=60 # Days to consider for frequency calculation
115-
SCORING_MIN_POSTS_FOR_FULL_FREQUENCY=45 # Min posts for full frequency score
114+
SCORING_SOCIAL_FREQUENCY_DAYS=30 # Days to consider for frequency calculation
115+
SCORING_MIN_POSTS_FOR_FULL_FREQUENCY=10 # Min posts for full frequency score
116116

117117
# Scoring Weight Configuration (Optional - defaults are used if not specified)
118118
SCORING_WEIGHT_PROJECT_INFO_QUALITY=10

TWITTER_FETCH_ISSUE_FINDINGS.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,15 @@ This shows:
2828
### 1. Social Media Frequency Evaluation Period
2929
- **Before**: 30 days lookback period
3030
- **After**: 60 days lookback period
31-
- **Config**: `SCORING_SOCIAL_FREQUENCY_DAYS=60`
31+
- **Config**: `SCORING_SOCIAL_FREQUENCY_DAYS=30`
3232

3333
### 2. Minimum Posts for Perfect Score
3434
- **Before**: 30 posts required for 100% score
3535
- **After**: 45 posts required for 100% score
36-
- **Config**: `SCORING_MIN_POSTS_FOR_FULL_FREQUENCY=45`
36+
- **Config**: `SCORING_MIN_POSTS_FOR_FULL_FREQUENCY=10`
3737

3838
### 3. Twitter Posts Lookback
39-
- **Config**: `TWITTER_POSTS_LOOKBACK_DAYS=60` (should match frequency period)
39+
- **Config**: `TWITTER_POSTS_LOOKBACK_DAYS=30` (should match frequency period)
4040

4141
### 4. Database Reset
4242
- **Action**: `POST /admin/reset-social-timestamps?clearPosts=true`
@@ -123,8 +123,8 @@ if (tweets.length >= this.maxTweetsToCollect) break;
123123

124124
**New Environment Variables**:
125125
```bash
126-
TWITTER_MAX_TWEETS_TO_COLLECT=50 # Maximum tweets to collect and store
127-
TWITTER_POSTS_LOOKBACK_DAYS=60 # Days to look back for posts
126+
TWITTER_MAX_TWEETS_TO_COLLECT=15 # Maximum tweets to collect and store
127+
TWITTER_POSTS_LOOKBACK_DAYS=30 # Days to look back for posts
128128
```
129129

130130
This ensures projects can now collect the 45+ posts needed for perfect frequency scores, and the limits are easily adjustable for future requirements.
@@ -175,9 +175,9 @@ curl "https://staging.eval.ads.giveth.io/admin/stats"
175175
Ensure these environment variables are set correctly:
176176

177177
```bash
178-
TWITTER_POSTS_LOOKBACK_DAYS=60 # TwitterService lookback
178+
TWITTER_POSTS_LOOKBACK_DAYS=30 # TwitterService lookback
179179
_DAYS=60 # ScoringService frequency period
180-
SCORING_MIN_POSTS_FOR_FULL_FREQUENCY=45 # Minimum posts for 100% score
180+
SCORING_MIN_POSTS_FOR_FULL_FREQUENCY=10 # Minimum posts for 100% score
181181
```
182182

183183
## Impact Assessment

src/modules/evaluation/PROJECT_EVALUATION_GUIDE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,8 @@ SCORING_WEIGHT_GIVPOWER_RANK=15 # Default: 15%
122122
```bash
123123
SCORING_UPDATE_RECENCY_DECAY_DAYS=30 # Default: 30 days for 50% score
124124
SCORING_SOCIAL_RECENCY_DECAY_DAYS=14 # Default: 14 days for 50% score
125-
SCORING_SOCIAL_FREQUENCY_DAYS=60 # Default: Consider last 60 days
126-
SCORING_MIN_POSTS_FOR_FULL_FREQUENCY=45 # Default: 45 posts for 100% score
125+
SCORING_SOCIAL_FREQUENCY_DAYS=30 # Default: Consider last 30 days
126+
SCORING_MIN_POSTS_FOR_FULL_FREQUENCY=10 # Default: 10 posts for 100% score
127127
```
128128

129129
## Error Handling Strategy

src/modules/scheduled-jobs/controllers/admin.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ export class AdminController {
657657

658658
// Retrieve social posts for multiple projects
659659
const defaultLimit = parseInt(
660-
this.configService.get('SOCIAL_POST_MAX_COUNT', '50'),
660+
this.configService.get('SOCIAL_POST_MAX_COUNT', '15'),
661661
10,
662662
);
663663
const result =

src/modules/scoring/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ Set these environment variables to customize scoring behavior:
6262
# Decay rates and thresholds
6363
SCORING_UPDATE_RECENCY_DECAY_DAYS=30 # Days for 50% score on update recency
6464
SCORING_SOCIAL_RECENCY_DECAY_DAYS=14 # Days for 50% score on social recency
65-
SCORING_SOCIAL_FREQUENCY_DAYS=60 # Days to consider for frequency calculation
66-
SCORING_MIN_POSTS_FOR_FULL_FREQUENCY=45 # Min posts for full frequency score
65+
SCORING_SOCIAL_FREQUENCY_DAYS=30 # Days to consider for frequency calculation
66+
SCORING_MIN_POSTS_FOR_FULL_FREQUENCY=10 # Min posts for full frequency score
6767

6868
# Optional: Custom scoring weights (must sum to 1.0)
6969
SCORING_WEIGHTS='{"projectInfoQuality":0.20,"updateRecency":0.10,"socialMediaQuality":0.20,"socialMediaRecency":0.05,"socialMediaFrequency":0.05,"relevanceToCause":0.20,"existingQualityScore":0.10,"givPowerRank":0.10}'

src/modules/scoring/scoring.service.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ describe('ScoringService', () => {
1919
const config: Record<string, any> = {
2020
SCORING_UPDATE_RECENCY_DECAY_DAYS: 30,
2121
SCORING_SOCIAL_RECENCY_DECAY_DAYS: 14,
22-
SCORING_SOCIAL_FREQUENCY_DAYS: 60,
23-
SCORING_MIN_POSTS_FOR_FULL_FREQUENCY: 45,
22+
SCORING_SOCIAL_FREQUENCY_DAYS: 30,
23+
SCORING_MIN_POSTS_FOR_FULL_FREQUENCY: 10,
2424
};
2525
return config[key] ?? defaultValue;
2626
}),

src/modules/scoring/scoring.service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,17 @@ export class ScoringService {
4545

4646
this.socialFrequencyDays = this.configService.get<number>(
4747
'SCORING_SOCIAL_FREQUENCY_DAYS',
48-
60, // Default: Consider posts from last 60 days
48+
30, // Default: Consider posts from last 30 days
4949
);
5050

5151
this.minPostsForFullFrequencyScore = this.configService.get<number>(
5252
'SCORING_MIN_POSTS_FOR_FULL_FREQUENCY',
53-
45, // Default: 45 posts in 60 days for full score
53+
10, // Default: 15 posts in 60 days for full score
5454
);
5555

5656
this.maxPostsForLLMAssessment = this.configService.get<number>(
5757
'SOCIAL_POST_MAX_COUNT',
58-
50, // Default: Use all stored posts for LLM assessment
58+
15, // Default: Use all stored posts for LLM assessment
5959
);
6060

6161
this.logger.log(

src/modules/social-media-storage/services/social-post-storage.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ export class SocialPostStorageService {
204204
}
205205

206206
const maxCount = parseInt(
207-
this.configService.get('SOCIAL_POST_MAX_COUNT', '50'),
207+
this.configService.get('SOCIAL_POST_MAX_COUNT', '15'),
208208
10,
209209
);
210210
const maxAgeDays = parseInt(

src/modules/social-media/services/farcaster.service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,11 @@ export class FarcasterService {
7272
maxRetries: this.configService.get<number>('FARCASTER_MAX_RETRIES', 3),
7373
lookbackDays: this.configService.get<number>(
7474
'FARCASTER_POSTS_LOOKBACK_DAYS',
75-
60,
75+
30,
7676
),
7777
maxPostsPerProject: this.configService.get<number>(
7878
'FARCASTER_MAX_POSTS_PER_PROJECT',
79-
10,
79+
15,
8080
),
8181
fidCacheTtl: this.configService.get<number>(
8282
'FARCASTER_FID_CACHE_TTL',
@@ -86,7 +86,7 @@ export class FarcasterService {
8686
'FARCASTER_CASTS_CACHE_TTL',
8787
3600,
8888
), // 1 hour
89-
batchSize: this.configService.get<number>('FARCASTER_BATCH_SIZE', 30),
89+
batchSize: this.configService.get<number>('FARCASTER_BATCH_SIZE', 15),
9090
};
9191

9292
this.logger.log(

0 commit comments

Comments
 (0)