config.php will not be written if it does not exist

[sebsel]

So, we write the config.php file if it's writeable, and if not, we show the user what to copy to the file by hand.

Since we don't ship with a config.php file, and since is_writeable() returns false when file does not exist, people will always have to copy it manually.

Maybe we should do a @touch($configfile); right before it? Suppressing any errors, because we check for writability next thing?

selfauth/setup.php

Line 138 in 7ef3947

if (is_writeable($configfile) && !$configured) {

Mentioning PR #27 here, because it's about cleaning up setup.php

[Zegnat]

I’d rather not first try and force the creation of a file.

If you want to keep all the separate logic we have now, the solution would be to extend the if-statement to check if the directory is writeable when the file doesn’t exist:

    if (!$configured && (
        is_writeable($configfile) ||
        !file_exists($configfile) && is_writeable(dirname($configfile))
    )) { 

But I would prefer dumbing down our code and swapping the entire file-write section with just one line:

$file_written = file_put_contents($configfile, $config_file_contents);

file_put_contents will (over)write or create the file, does exactly what we currently do (it “is identical to calling fopen(), fwrite() and fclose() successively”), and will set $file_written to false if something went wrong so we can tell people to manually copy the file contents.