fix: resolve CI build failure and address review feedback

- Fix std::pair CTAD failure that broke Linux/macOS builds: a raw
  function name deduces to a function type (not a pointer), which
  std::pair cannot hold. Reuse the existing NamedApplier struct instead.
- Make TempIniFile's constructor/destructor non-throwing (error_code
  overload of fs::remove) to avoid std::terminate on cleanup failure
- Drop unnecessary fs::remove(defaultWindowParametersFilename) calls;
  every test uses explicit positive dimensions and its own load(), so
  the shared default INI is never actually read
- Extract the duplicated colorsEqual helper into test_helpers.h
- Use TempIniFile's RAII cleanup instead of manual fs::remove in the
  three tests that still did it by hand

Co-Authored-By: Claude <noreply@anthropic.com>

Author: Jgocunha

imgui-platform-kit/tests/test_helpers.h

@@ -14,6 +14,14 @@
 
 namespace imgui_kit::testing
 {
+    // Exact (non-approximate) ImVec4 comparison — the values under test are
+    // always literal source constants or copies of them, so bit-for-bit
+    // equality is expected and any divergence is a real regression.
+    inline bool colorsEqual(const ImVec4& a, const ImVec4& b)
+    {
+        return a.x == b.x && a.y == b.y && a.z == b.z && a.w == b.w;
+    }
+
     class ImGuiContextFixture
     {
     public:

imgui-platform-kit/tests/test_parameters_edge_cases.cpp

@@ -21,12 +21,17 @@ namespace
         explicit TempIniFile(const std::string& name, const std::string& content)
             : path((fs::temp_directory_path() / name).string())
         {
-            fs::remove(path);
+            std::error_code ec;
+            fs::remove(path, ec);
             std::ofstream out(path);
             out << content;
         }
 
-        ~TempIniFile() { fs::remove(path); }
+        ~TempIniFile()
+        {
+            std::error_code ec;
+            fs::remove(path, ec);
+        }
 
         TempIniFile(const TempIniFile&) = delete;
         TempIniFile& operator=(const TempIniFile&) = delete;
@@ -45,39 +50,34 @@ TEST_CASE("WindowParameters: load throws std::invalid_argument on malformed Widt
     // Pins current behavior: load() does not validate numeric fields; a
     // corrupt INI throws a raw std::invalid_argument out of std::stoi.
     TempIniFile ini("ipk_edge_bad_width.ini", "[Window Parameters]\nWidth=abc\n");
-    fs::remove(defaultWindowParametersFilename);
     WindowParameters p("App", 800, 600);
     CHECK_THROWS_AS(p.load(ini.str()), std::invalid_argument);
 }
 
 TEST_CASE("WindowParameters: load throws std::invalid_argument on malformed Height", "[parameters][window][io][edge]")
 {
     TempIniFile ini("ipk_edge_bad_height.ini", "[Window Parameters]\nHeight=xyz\n");
-    fs::remove(defaultWindowParametersFilename);
     WindowParameters p("App", 800, 600);
     CHECK_THROWS_AS(p.load(ini.str()), std::invalid_argument);
 }
 
 TEST_CASE("WindowParameters: load throws std::invalid_argument on malformed StartPosX", "[parameters][window][io][edge]")
 {
     TempIniFile ini("ipk_edge_bad_startposx.ini", "[Window Parameters]\nStartPosX=notanumber\n");
-    fs::remove(defaultWindowParametersFilename);
     WindowParameters p("App", 800, 600);
     CHECK_THROWS_AS(p.load(ini.str()), std::invalid_argument);
 }
 
 TEST_CASE("WindowParameters: load throws std::invalid_argument on malformed StartPosY", "[parameters][window][io][edge]")
 {
     TempIniFile ini("ipk_edge_bad_startposy.ini", "[Window Parameters]\nStartPosY=??\n");
-    fs::remove(defaultWindowParametersFilename);
     WindowParameters p("App", 800, 600);
     CHECK_THROWS_AS(p.load(ini.str()), std::invalid_argument);
 }
 
 TEST_CASE("WindowParameters: load throws std::out_of_range on an overflowing value", "[parameters][window][io][edge]")
 {
     TempIniFile ini("ipk_edge_overflow.ini", "[Window Parameters]\nWidth=99999999999999999999\n");
-    fs::remove(defaultWindowParametersFilename);
     WindowParameters p("App", 800, 600);
     CHECK_THROWS_AS(p.load(ini.str()), std::out_of_range);
 }
@@ -87,7 +87,6 @@ TEST_CASE("WindowParameters: load throws std::out_of_range on an overflowing val
 TEST_CASE("WindowParameters: partial file only updates the keys present", "[parameters][window][io][edge]")
 {
     TempIniFile ini("ipk_edge_partial.ini", "[Window Parameters]\nTitle=OnlyTitle\n");
-    fs::remove(defaultWindowParametersFilename);
     WindowParameters p("Original", 1280, 720, 5, 6);
 
     p.load(ini.str());
@@ -103,7 +102,6 @@ TEST_CASE("WindowParameters: unknown keys are ignored", "[parameters][window][io
 {
     TempIniFile ini("ipk_edge_unknown_keys.ini",
         "[Window Parameters]\nNonsense=42\nDepth=3\nTitle=KnownTitle\n");
-    fs::remove(defaultWindowParametersFilename);
     WindowParameters p("Original", 1280, 720);
 
     REQUIRE_NOTHROW(p.load(ini.str()));
@@ -115,7 +113,6 @@ TEST_CASE("WindowParameters: unknown keys are ignored", "[parameters][window][io
 TEST_CASE("WindowParameters: empty file is a no-op on all fields", "[parameters][window][io][edge]")
 {
     TempIniFile ini("ipk_edge_empty.ini", "");
-    fs::remove(defaultWindowParametersFilename);
     WindowParameters p("Original", 1280, 720, 5, 6);
 
     p.load(ini.str());
@@ -130,7 +127,6 @@ TEST_CASE("WindowParameters: empty file is a no-op on all fields", "[parameters]
 TEST_CASE("WindowParameters: the [Window Parameters] header line is ignored", "[parameters][window][io][edge]")
 {
     TempIniFile ini("ipk_edge_header_only.ini", "[Window Parameters]\n");
-    fs::remove(defaultWindowParametersFilename);
     WindowParameters p("Original", 1280, 720, 5, 6);
 
     REQUIRE_NOTHROW(p.load(ini.str()));
@@ -142,8 +138,8 @@ TEST_CASE("WindowParameters: the [Window Parameters] header line is ignored", "[
 
 TEST_CASE("WindowParameters: title containing spaces and '=' round-trips exactly", "[parameters][window][io][edge]")
 {
-    const std::string path = (fs::temp_directory_path() / "ipk_edge_weird_title.ini").string();
-    fs::remove(path);
+    TempIniFile ini("ipk_edge_weird_title.ini", "");
+    const std::string& path = ini.str();
 
     const WindowParameters saved("My = Weird == Title", 1280, 720, 1, 2);
     saved.save(path);
@@ -152,8 +148,6 @@ TEST_CASE("WindowParameters: title containing spaces and '=' round-trips exactly
     loaded.load(path);
 
     CHECK(loaded.title == "My = Weird == Title");
-
-    fs::remove(path);
 }
 
 // ─── negative/zero values bypass validation on load() ──────────────────────────
@@ -163,7 +157,6 @@ TEST_CASE("WindowParameters: load stores negative values without validation", "[
     // The width/height > 0 validation only runs in the constructor's
     // monitor-fallback logic, not in load() itself — load() bypasses it.
     TempIniFile ini("ipk_edge_negative.ini", "[Window Parameters]\nWidth=-500\nHeight=-1\n");
-    fs::remove(defaultWindowParametersFilename);
     WindowParameters p("App", 800, 600);
 
     REQUIRE_NOTHROW(p.load(ini.str()));
@@ -181,32 +174,25 @@ static std::string readFile(const std::string& path)
 
 TEST_CASE("WindowParameters: save() is deterministic and writes exactly 6 lines", "[parameters][window][io][edge]")
 {
-    const std::string pathA = (fs::temp_directory_path() / "ipk_edge_det_a.ini").string();
-    const std::string pathB = (fs::temp_directory_path() / "ipk_edge_det_b.ini").string();
-    fs::remove(pathA);
-    fs::remove(pathB);
+    TempIniFile iniA("ipk_edge_det_a.ini", "");
+    TempIniFile iniB("ipk_edge_det_b.ini", "");
 
-    fs::remove(defaultWindowParametersFilename);
     const WindowParameters p("Deterministic", 1024, 768, 3, 4);
-    p.save(pathA);
-    p.save(pathB);
+    p.save(iniA.str());
+    p.save(iniB.str());
 
-    const std::string contentA = readFile(pathA);
-    const std::string contentB = readFile(pathB);
+    const std::string contentA = readFile(iniA.str());
+    const std::string contentB = readFile(iniB.str());
     CHECK(contentA == contentB);
 
     const auto lineCount = std::count(contentA.begin(), contentA.end(), '\n');
     CHECK(lineCount == 6);
-
-    fs::remove(pathA);
-    fs::remove(pathB);
 }
 
 // ─── save() throws with message on unopenable path ────────────────────────────
 
 TEST_CASE("WindowParameters: save() throws with a descriptive message on an unopenable path", "[parameters][window][io][edge]")
 {
-    fs::remove(defaultWindowParametersFilename);
     const WindowParameters p("App", 800, 600);
     CHECK_THROWS_WITH(
         p.save("this/directory/does/not/exist/file.ini"),
@@ -217,16 +203,13 @@ TEST_CASE("WindowParameters: save() throws with a descriptive message on an unop
 
 TEST_CASE("UserInterfaceParameters: save() with a custom filename delegates to WindowParameters::save()", "[parameters][io][edge]")
 {
-    const std::string path = (fs::temp_directory_path() / "ipk_edge_uiparams.ini").string();
-    fs::remove(path);
+    TempIniFile ini("ipk_edge_uiparams.ini", "");
 
     const UserInterfaceParameters params(WindowParameters("Delegated", 800, 600, 0, 0));
-    params.save(path);
+    params.save(ini.str());
 
-    REQUIRE(fs::exists(path));
-    const std::string content = readFile(path);
+    REQUIRE(fs::exists(ini.str()));
+    const std::string content = readFile(ini.str());
     CHECK(content.rfind("[Window Parameters]", 0) == 0);
     CHECK(content.find("Title=Delegated") != std::string::npos);
-
-    fs::remove(path);
 }

imgui-platform-kit/tests/test_style_parameters_apply.cpp

@@ -20,11 +20,6 @@ static const std::vector<Theme> ALL_THEMES = {
     Theme::LedSynthmaster,
 };
 
-static bool colorsEqual(const ImVec4& a, const ImVec4& b)
-{
-    return a.x == b.x && a.y == b.y && a.z == b.z && a.w == b.w;
-}
-
 // ─── apply() dispatches to the matching themes[] entry ───────────────────────
 
 TEST_CASE("StyleParameters: apply() applies the selected theme for every Theme value", "[parameters][apply]")

imgui-platform-kit/tests/test_template_window.cpp

@@ -20,11 +20,6 @@ namespace
         return std::make_unique<TemplateWindow>();
     }
 
-    bool colorsEqual(const ImVec4& a, const ImVec4& b)
-    {
-        return a.x == b.x && a.y == b.y && a.z == b.z && a.w == b.w;
-    }
-
     // template_window.cpp unconditionally calls ImPlot::ShowDemoWindow(), so
     // every test needs a live ImPlot context alongside the ImGui one. Created
     // after the ImGui context, destroyed before it dies.

imgui-platform-kit/tests/test_theme_selector.cpp

@@ -13,11 +13,6 @@ using namespace imgui_kit::testing;
 // therefore cover every line reachable without that interaction: the window
 // wrapper, the combo header, and the closed-combo path.
 
-static bool colorsEqual(const ImVec4& a, const ImVec4& b)
-{
-    return a.x == b.x && a.y == b.y && a.z == b.z && a.w == b.w;
-}
-
 TEST_CASE("ThemeSelector: renders with nullptr open flag", "[themeselector][render]")
 {
     ImGuiFrameFixture fixture;

imgui-platform-kit/tests/test_themes_apply.cpp

@@ -59,11 +59,6 @@ static const std::vector<NamedApplier> ALL_APPLIERS = {
 
 static constexpr int EXPECTED_APPLIER_COUNT = 36;
 
-static bool colorsEqual(const ImVec4& a, const ImVec4& b)
-{
-    return a.x == b.x && a.y == b.y && a.z == b.z && a.w == b.w;
-}
-
 static bool styleEqual(const ImGuiStyle& a, const ImGuiStyle& b)
 {
     for (int i = 0; i < ImGuiCol_COUNT; ++i)
@@ -210,12 +205,18 @@ TEST_CASE("Themes: applying a theme is idempotent", "[themes][apply]")
 {
     ImGuiContextFixture fixture;
 
-    for (const auto& applier : {std::pair{"Cherry", applyCherryTheme}, std::pair{"Darcula", applyDarculaTheme}, std::pair{"Gold", applyGoldTheme}})
+    const std::vector<NamedApplier> subset = {
+        {"Cherry", applyCherryTheme},
+        {"Darcula", applyDarculaTheme},
+        {"Gold", applyGoldTheme},
+    };
+
+    for (const auto& applier : subset)
     {
-        INFO("Theme: " << applier.first);
-        applier.second();
+        INFO("Theme: " << applier.name);
+        applier.fn();
         const ImGuiStyle first = ImGui::GetStyle();
-        applier.second();
+        applier.fn();
         const ImGuiStyle second = ImGui::GetStyle();
         CHECK(styleEqual(first, second));
     }