SVT:Expansion variables needs an improvement for windows

[jagraj]

Describe the bug
I am trying to consume new feature expansion variables with liberty maven plugin version 3.12.1. I followed this documentation for windows operating system.

When I try to run liberty tools in dev mode then I noticed expansion variables are not processed properly. I am not sure if this is tools defect or we need an improvement to our docs.

LIBERTY_INSTALL_DIR=C:\MyData\LibertyInstalls
IBM_JAVA_SEMERU_HOME=C:\MyData\java\ibm-semeru-certified
JAVA_HOME=!IBM_JAVA_SEMERU_HOME!\jdk-21.0.10+7

 [INFO] Resolving Property IBM_JAVA_SEMERU_HOME for expression !IBM_JAVA_SEMERU_HOME!jdk-21.0.10+7. Resolved expression value is C:MyDatajavaibm-semeru-certified

I have to use escape back slash \ for the windows path separator to work then the expansion variables processed correctly. Here are the changes that I made in server.env file.

LIBERTY_INSTALL_DIR=C:\\MyData\\LibertyInstalls
IBM_JAVA_SEMERU_HOME=C:\\MyData\\java\\ibm-semeru-certified
JAVA_HOME=!IBM_JAVA_SEMERU_HOME!\\jdk-21.0.10+7

[INFO] Resolving Property IBM_JAVA_SEMERU_HOME for expression !IBM_JAVA_SEMERU_HOME!\jdk-21.0.10+7. Resolved expression value is C:\MyData\java\ibm-semeru-certified

I think we need to fix the documentation or fix the tools code when processing these expansion variables.

Steps to Reproduce
Install liberty latest build on Windows
Create liberty server with expansion variables in server.env variables as stated in this problem above.
Start liberty server in dev mode using Liberty tools eclipse plugin
You can see in the console how these variables are processing

Expected behavior
I think we need to change the documentation or fix the tools code when processing these expansion variables.

Diagnostic information:

• OpenLiberty Version: wlp-1.0.116.cl260920260730-0309
• Affected feature(s) [e.g. mpHealth-3.0]
• Java Version: 21.0.10, 21.0.10+7-LTS

Additional context
Add any other context about the problem here.

[cherylking]

@jagraj Did you test the behavior regarding the single backslash and double backslash with Liberty itself without the plugins? The documentation you pointed to is Liberty's doc not the plugins. So I am wondering if this is a Liberty bug and/or Liberty doc change is required. Also need to rule out whether it is just a print problem when the plugins display the resolved value. In other words, did the expansion actually work under the covers for whatever your application is trying to do?

[jagraj]

@cherylking
I and @venmanyarun had a working session this morning about this problem, Here is another issue (#2078) that I opened regarding the windows path separator issue when I try to enable <mergeServerEnv>true</mergeServerEnv> property.

[venmanyarun]

@sajeerzeji
The issue here is that backslashes in message is being ignored while printing and the message seems to be implying the action incorrectly. Please make changes in ci.common, and we need to fix some IT's in ci.gradle and ci.maven

I would recommend something like

[INFO] Resolved environment variable "IBM_JAVA_SEMERU_HOME" in path "!IBM_JAVA_SEMERU_HOME!\jdk-21.0.10+7" to "C:\MyData\java\ibm-semeru-certified\jdk-21.0.10+7" -> show full value here