Merge pull request #107 from ReturnInfinity/qa

Qa

Author: IanSeyler

docs/README.md

@@ -216,7 +216,7 @@ The Pure64 information table is located at `0x0000000000005000` and ends at `0x0
 <tr><td>0x50E1</td><td>8-bit</td><td>FLAG_X2APIC</td><td>1 if X2APIC is supported</td></tr>
 <tr><td>0x50E2</td><td>8-bit</td><td>FLAG_BOOTMODE</td><td>'B' if BIOS, 'U' for UEFI</td></tr>
 <tr><td>0x50E3 - 0x50FF</td><td>&nbsp;</td><td>&nbsp;</td><td>For future use</td></tr>
-<tr><td>0x5100 - 0x51FF</td><td>8-bit</td><td>APIC_ID</td><td>APIC ID's for valid CPU cores (based on CORES_ACTIVE)</td></tr>
+<tr><td>0x5100 - 0x51FF</td><td>32-bit</td><td>APIC_ID</td><td>APIC ID's for valid CPU cores (based on CORES_ACTIVE)</td></tr>
 <tr><td>0x5200 - 0x53FF</td><td>&nbsp;</td><td>&nbsp;</td><td>For future use</td></tr>
 <tr><td>0x5400 - 0x55FF</td><td>16 byte entries</td><td>PCIE</td><td>PCIe bus data</td></tr>
 <tr><td>0x5600 - 0x56FF</td><td>16 byte entries</td><td>IOAPIC</td><td>I/O APIC addresses (based on IOAPIC_COUNT)</td></tr>

src/pure64.asm

@@ -712,8 +712,7 @@ create_pdpe_high:
 	stosq
 	add rax, 0x00001000		; 4K later (512 records x 8 bytes)
 	dec ecx
-	cmp ecx, 0
-	jne create_pdpe_high
+	jnz create_pdpe_high
 
 ; Create the High Page-Directory Entries (PDE).
 ; A single PDE can map 2MiB of RAM
@@ -737,11 +736,8 @@ skipfirst4mb:
 pde_high:				; Create a 2MiB page
 	stosq
 	add rax, 0x00200000		; Increment by 2MiB
-	cmp ecx, 0
-	je pde_next_range
 	dec ecx
-	cmp ecx, 0
-	jne pde_high
+	jnz pde_high
 	jmp pde_next_range
 pde_end:
 

src/sysvar.asm

@@ -39,7 +39,7 @@ VBEModeInfoBlock:	equ 0x0000000000005F00		; 256 bytes
 ; DQ - Starting at offset 0, increments by 0x8
 p_ACPITableAddress:	equ SystemVariables + 0x00
 p_HPET_CyclesPerUs:	equ SystemVariables + 0x08	; Precomputed HPET cycles per microsecond
-p_LocalAPICAddress:	equ SystemVariables + 0x10
+p_LocalAPICAddress:	equ SystemVariables + 0x10	; Address of the Local APIC (xAPIC)
 p_HPET_Address:		equ SystemVariables + 0x28
 sys_timer:		equ SystemVariables + 0x30
 p_EBDA:			equ SystemVariables + 0x38