From 95e8e19f3c3aecfe729b5d8942d840189e3341d4 Mon Sep 17 00:00:00 2001 From: Adam Dangoor Date: Thu, 6 Aug 2026 05:22:08 +0100 Subject: [PATCH] Require explicit content_type in test helpers Co-Authored-By: Claude Opus 5 (1M context) --- tests/mock_vws/test_add_target.py | 65 +++++++++++++++++++++++----- tests/mock_vws/test_update_target.py | 11 ++++- 2 files changed, 63 insertions(+), 13 deletions(-) diff --git a/tests/mock_vws/test_add_target.py b/tests/mock_vws/test_add_target.py index 1703004ee..b22ecfd56 100644 --- a/tests/mock_vws/test_add_target.py +++ b/tests/mock_vws/test_add_target.py @@ -39,7 +39,7 @@ def _add_target_to_vws( *, vws_client: VWS, data: dict[str, Any], - content_type: str = "application/json", + content_type: str, ) -> Response: """Return a response from a request to the endpoint to add a target. @@ -195,7 +195,11 @@ def test_missing_data( data.pop(data_to_remove) with pytest.raises(expected_exception=FailError) as exc: - _add_target_to_vws(vws_client=vws_client, data=data) + _add_target_to_vws( + vws_client=vws_client, + data=data, + content_type="application/json", + ) assert_vws_failure( response=exc.value.response, @@ -233,7 +237,11 @@ def test_width_invalid( } with pytest.raises(expected_exception=FailError) as exc: - _add_target_to_vws(vws_client=vws_client, data=data) + _add_target_to_vws( + vws_client=vws_client, + data=data, + content_type="application/json", + ) assert_vws_failure( response=exc.value.response, @@ -343,10 +351,18 @@ def test_name_invalid( if status_code == HTTPStatus.INTERNAL_SERVER_ERROR: with pytest.raises(expected_exception=ServerError) as exc: - _add_target_to_vws(vws_client=vws_client, data=data) + _add_target_to_vws( + vws_client=vws_client, + data=data, + content_type="application/json", + ) else: with pytest.raises(expected_exception=FailError) as exc: - _add_target_to_vws(vws_client=vws_client, data=data) + _add_target_to_vws( + vws_client=vws_client, + data=data, + content_type="application/json", + ) assert_vws_failure( response=exc.value.response, @@ -573,7 +589,11 @@ def test_not_base64_encoded_processable( } with pytest.raises(expected_exception=BadImageError) as exc: - _add_target_to_vws(vws_client=vws_client, data=data) + _add_target_to_vws( + vws_client=vws_client, + data=data, + content_type="application/json", + ) assert_vws_failure( response=exc.value.response, @@ -600,7 +620,11 @@ def test_not_base64_encoded_not_processable( } with pytest.raises(expected_exception=FailError) as exc: - _add_target_to_vws(vws_client=vws_client, data=data) + _add_target_to_vws( + vws_client=vws_client, + data=data, + content_type="application/json", + ) assert_vws_failure( response=exc.value.response, @@ -648,7 +672,11 @@ def test_invalid_type( } with pytest.raises(expected_exception=FailError) as exc: - _add_target_to_vws(vws_client=vws_client, data=data) + _add_target_to_vws( + vws_client=vws_client, + data=data, + content_type="application/json", + ) assert_vws_failure( response=exc.value.response, @@ -749,7 +777,9 @@ def test_not_set( "image": image_data_encoded, } - response = _add_target_to_vws(vws_client=vws_client, data=data) + response = _add_target_to_vws( + vws_client=vws_client, data=data, content_type="application/json" + ) response_json = json.loads(s=response.text) target_id = response_json["target_id"] target_details = vws_client.get_target_record(target_id=target_id) @@ -774,7 +804,9 @@ def test_set_to_none( "active_flag": None, } - response = _add_target_to_vws(vws_client=vws_client, data=data) + response = _add_target_to_vws( + vws_client=vws_client, data=data, content_type="application/json" + ) response_json = json.loads(s=response.text) target_id = response_json["target_id"] @@ -812,7 +844,11 @@ def test_invalid_extra_data( } with pytest.raises(expected_exception=FailError) as exc: - _add_target_to_vws(vws_client=vws_client, data=data) + _add_target_to_vws( + vws_client=vws_client, + data=data, + content_type="application/json", + ) assert_vws_failure( response=exc.value.response, @@ -875,6 +911,7 @@ def test_null( response = _add_target_to_vws( vws_client=vws_client, data=request_data, + content_type="application/json", ) assert_success(response=response) @@ -902,7 +939,11 @@ def test_invalid_type( } with pytest.raises(expected_exception=FailError) as exc: - _add_target_to_vws(vws_client=vws_client, data=data) + _add_target_to_vws( + vws_client=vws_client, + data=data, + content_type="application/json", + ) assert_vws_failure( response=exc.value.response, diff --git a/tests/mock_vws/test_update_target.py b/tests/mock_vws/test_update_target.py index 20245ba1a..29ab78483 100644 --- a/tests/mock_vws/test_update_target.py +++ b/tests/mock_vws/test_update_target.py @@ -38,7 +38,7 @@ def _update_target( vws_client: VWS, data: dict[str, Any], target_id: str, - content_type: str = "application/json", + content_type: str, ) -> Response: """Make a request to the endpoint to update a target. @@ -160,6 +160,7 @@ def test_no_fields_given( vws_client=vws_client, data={}, target_id=target_id, + content_type="application/json", ) assert_vws_response( @@ -203,6 +204,7 @@ def test_invalid_extra_data( vws_client=vws_client, data={"extra_thing": 1}, target_id=target_id, + content_type="application/json", ) assert_vws_failure( @@ -239,6 +241,7 @@ def test_width_invalid( vws_client=vws_client, data={"width": width}, target_id=target_id, + content_type="application/json", ) assert_vws_failure( @@ -321,6 +324,7 @@ def test_invalid( vws_client=vws_client, data={"active_flag": desired_active_flag}, target_id=target_id, + content_type="application/json", ) assert_vws_failure( @@ -375,6 +379,7 @@ def test_invalid_type( vws_client=vws_client, data={"application_metadata": invalid_metadata}, target_id=target_id, + content_type="application/json", ) assert_vws_failure( @@ -538,6 +543,7 @@ def test_name_invalid( vws_client=vws_client, data={"name": name}, target_id=target_id, + content_type="application/json", ) assert_vws_failure( @@ -759,6 +765,7 @@ def test_not_base64_encoded_processable( vws_client=vws_client, data={"image": not_base64_encoded_processable}, target_id=target_id, + content_type="application/json", ) assert_vws_failure( @@ -787,6 +794,7 @@ def test_not_base64_encoded_not_processable( vws_client=vws_client, data={"image": not_base64_encoded_not_processable}, target_id=target_id, + content_type="application/json", ) assert_vws_failure( @@ -835,6 +843,7 @@ def test_invalid_type( vws_client=vws_client, data={"image": invalid_type_image}, target_id=target_id, + content_type="application/json", ) assert_vws_failure(