refactoring(migrations): unit test signal migration adjustment

Move unit test from spec file to golden test

Author: aparzi

packages/core/schematics/migrations/signal-migration/test/golden-test/input_function_that_reference_this.ts

@@ -0,0 +1,8 @@
+// tslint:disable
+
+import {Input} from '@angular/core';
+
+export class TestComponent {
+  @Input() fnDisplay = (item: any) => item;
+  @Input() fnEquals = (a: any, b: any) => this.fnDisplay(a) === this.fnDisplay(b);
+}

packages/core/schematics/migrations/signal-migration/test/golden.txt

@@ -749,6 +749,18 @@ import {Component, input} from '@angular/core';
 export class InlineTmpl {
   readonly justify = input<'start' | 'end'>('end');
 }
+@@@@@@ input_function_that_reference_this.ts @@@@@@
+
+// tslint:disable
+
+import {input} from '@angular/core';
+
+export class TestComponent {
+
+  readonly fnDisplay = input((item: any) => item);
+  @Input() fnEquals = (a: any, b: any) => this.fnDisplay()(a) === this.fnDisplay()(b);
+
+}
 @@@@@@ jit_true_component_external_tmpl.html @@@@@@
 
 {{test()}}

packages/core/schematics/migrations/signal-migration/test/golden_best_effort.txt

@@ -719,6 +719,18 @@ import {Component, input} from '@angular/core';
 export class InlineTmpl {
   readonly justify = input<'start' | 'end'>('end');
 }
+@@@@@@ input_function_that_reference_this.ts @@@@@@
+
+// tslint:disable
+
+import {input} from '@angular/core';
+
+export class TestComponent {
+
+  readonly fnDisplay = input((item: any) => item);
+  @Input() fnEquals = (a: any, b: any) => this.fnDisplay()(a) === this.fnDisplay()(b);
+
+}
 @@@@@@ jit_true_component_external_tmpl.html @@@@@@
 
 {{test()}}

packages/core/schematics/test/signal_input_migration_spec.ts

@@ -128,30 +128,6 @@ describe('signal input migration', () => {
     expect(messages).toContain(`  -> Migrated 1/2 inputs.`);
   });
 
-  it('should not migrate input functions that reference this', async () => {
-    const source = `
-      import {Component, Input} from '@angular/core';
-
-      @Component({})
-      export class TestComponent {
-
-        @Input() fnDisplay = (item: any) => item;
-        @Input() fnEquals = (a: any, b: any) => this.fnDisplay(a) === this.fnDisplay(b);
-
-      }
-    `;
-
-    writeFile('/index.ts', source);
-    await runMigration();
-    const content = tree.readContent('/index.ts');
-
-    // Verify the simple function was migrated
-    expect(content).toContain('readonly fnDisplay = input((item: any) => item);');
-    expect(content).toContain(
-      '@Input() fnEquals = (a: any, b: any) => this.fnDisplay()(a) === this.fnDisplay()(b);',
-    );
-  });
-
   it('should report correct statistics with best effort mode', async () => {
     writeFile(`node_modules/@tsconfig/strictest/tsconfig.json`, `{}`);
     writeFile(