refactor: Support Explicit Resource Management on PendingTasks

Support Explicit Resource Management on PendingTasks

fixes angular#64742

Author: aparzi

packages/core/src/pending_tasks.ts

@@ -46,7 +46,7 @@ export class PendingTasks {
    */
   add(): () => void {
     const taskId = this.internalPendingTasks.add();
-    return () => {
+    const cleanup = () => {
       if (!this.internalPendingTasks.has(taskId)) {
         // This pending task has already been cleared.
         return;
@@ -55,6 +55,8 @@ export class PendingTasks {
       this.scheduler.notify(NotificationSource.PendingTaskRemoved);
       this.internalPendingTasks.remove(taskId);
     };
+    cleanup[Symbol.dispose] = cleanup;
+    return cleanup;
   }
 
   /**

packages/core/test/acceptance/pending_tasks_spec.ts

@@ -113,6 +113,21 @@ describe('public PendingTasks', () => {
     await expectAsync(appRef.whenStable()).toBeResolved();
     expect(spy).toHaveBeenCalled();
   });
+
+  it('should allow calling cleanup function multiple times', async () => {
+    const appRef = TestBed.inject(ApplicationRef);
+    const pendingTasks = TestBed.inject(PendingTasks);
+
+    const removeTask = pendingTasks.add();
+    await expectAsync(applicationRefIsStable(appRef)).toBeResolvedTo(false);
+
+    removeTask();
+    removeTask();
+    removeTask();
+
+    TestBed.inject(ApplicationRef).tick();
+    await expectAsync(applicationRefIsStable(appRef)).toBeResolvedTo(true);
+  });
 });
 
 function applicationRefIsStable(applicationRef: ApplicationRef) {

packages/tsconfig-build.json

@@ -19,7 +19,7 @@
     "moduleResolution": "bundler",
     "module": "esnext",
     "target": "es2022",
-    "lib": ["es2020", "es2022", "dom", "dom.iterable"],
+    "lib": ["es2020", "es2022", "esnext", "dom", "dom.iterable"],
     "skipLibCheck": true,
     // don't auto-discover @types/node, it results in a ///<reference in the .d.ts output
     "types": [],