shaderc as a static library: almost there

[npnp]

Hello everyone,

I'm trying to use shaderc as a library, to be able to compile shaders at runtime(from/to memory), but I had a few issues with duplicate symbols with bgfx.

If I change a few files in tools/shaderc folder to reference the stuff from the main bgfx(mostly removing implementations of duplicate functions), I can get my app to compile. This will probably break making shaderc executable unless it's linked with bgfx lib.

I was wondering if it makes sense to change the shaderc a bit more so that it's easier to use in this scenario?

I'm up for doing it and creating a pull request, but maybe it's better if we discuss it first a bit.

Is it a good approach to change shaderc source to use functions from bgfx and link the shaderc executable with the main bgfx library?

Maybe there is a better solution, perhaps renaming the bgfx namespace in shaderc?

Thanks for your input!
nesa

[bkaradzic]

This is not desirable feature. There are supported platforms where this can't be done.

[npnp]

Ok, I understand that - but what about changing the shaderc so that people who need to use it at runtime can do it without modifying the code?
I don't think it's necessary to add and support the library as a part of main bgfx distro, but being able to build both in same executable would be lovely(and it's almost there).

[bkaradzic]

Because there is better way of doing it, by executing external process. Whatever API you're using to compile shader, can be internally writing your shader into temp file, executing shaderc process to compile, and then immediately loading produced binary, and returning it to you. There is no difference from your API point of view, but you won't bloat executable with multiple compilers.

[npnp]

Sure, but then one has to deal with temporary file cleanup and permissions plus some platforms that are becoming unbearable anyway(apple) are making it harder and harder to launch external processes.
Perhaps there is something that would make bgfx harder to maintain if we would do such a change?

[matheusrsimon]

@npnp

Hey man, I've forked bgfx and integrated brtshaderc so it now can compile shaders at runtime in a limited number of platforms, as @bkaradzic said.

[alexkunesh]

This would nice to have for compile-time asset processors, regardless of platform support.