bimg & linux: undefined reference to `mz_compressBound'

[thomasreiser]

I am building bgfx with the following command line since a while:

(cd thirdparty/bgfx/bgfx && ../bx/tools/bin/linux/genie --with-dynamic-runtime --with-examples --with-tools --os=linux --gcc=linux-gcc gmake)
make -C thirdparty/bgfx/bgfx/.build/projects/gmake-linux config=release64 CXXFLAGS=-fPIC

This worked in the past (I haven't re-compiled it for a while) and now I have an issue when I am statically linking all the resulting libraries:

[build] /usr/bin/ld: ../thirdparty/bgfx/bin/libbimg_decode-linux-9d5b980f5c060e54cc30dec18500a5b54db00405-d-x86_64.a(image_decode.o): in function `tinyexr::CompressZip(unsigned char*, unsigned long&, unsigned char const*, unsigned long)':
[build] /myproj/thirdparty/bgfx/bgfx/.build/projects/gmake-linux/../../../../bimg/3rdparty/tinyexr/tinyexr.h:1268: undefined reference to `mz_compressBound'
[build] /usr/bin/ld: /myproj/thirdparty/bgfx/bgfx/.build/projects/gmake-linux/../../../../bimg/3rdparty/tinyexr/tinyexr.h:1269: undefined reference to `mz_compress'
[build] /usr/bin/ld: ../thirdparty/bgfx/bin/libbimg_decode-linux-9d5b980f5c060e54cc30dec18500a5b54db00405-d-x86_64.a(image_decode.o): in function `tinyexr::DecompressZip(unsigned char*, unsigned long*, unsigned char const*, unsigned long)':
[build] /myproj/thirdparty/bgfx/bgfx/.build/projects/gmake-linux/../../../../bimg/3rdparty/tinyexr/tinyexr.h:1305: undefined reference to `mz_uncompress'
[build] /usr/bin/ld: ../thirdparty/bgfx/bin/libbimg_decode-linux-9d5b980f5c060e54cc30dec18500a5b54db00405-d-x86_64.a(image_decode.o): in function `tinyexr::EncodePixelData(std::vector<unsigned char, std::allocator<unsigned char> >&, unsigned char const* const*, int, int, int, int, int, int, int, unsigned long, std::vector<tinyexr::ChannelInfo, std::allocator<tinyexr::ChannelInfo> > const&, std::vector<unsigned long, std::allocator<unsigned long> > const&, void const*)':
[build] /myproj/thirdparty/bgfx/bgfx/.build/projects/gmake-linux/../../../../bimg/3rdparty/tinyexr/tinyexr.h:6499: undefined reference to `mz_compressBound'

Whats going on with miniz? The same process works with macOS without any problem.

[bkaradzic]

Make sure you do clean build.

[thomasreiser]

Linking error occurs with a clean build, too (also in CI workflow).

[bkaradzic]

https://github.com/bkaradzic/bgfx/actions/runs/4191141648

[thomasreiser]

I know it compiles correctly but it failed linking the whole app together. I am actively using bimg_decode in my app and this seems for some reason to break everything in the linking process.

I have now fixed it on my side by adding path.join(BIMG_DIR, "3rdparty/tinyexr/deps/miniz/miniz.*"), to bimg_decode.lua (files section).

Can you maybe have a look? I could create a PR for that..