Support for docker with version later than 29.0.0

[qhyou11]

There are breaking changes: https://docs.docker.com/engine/deprecated/#deprecate-legacy-api-versions
With Docker 29.0.0 as CRI, chaosblade reported the following errror:

 level=error msg="`GetContainerList`: container exec failed, err: Error response from daemon: client version 1.24 is too old. Minimum supported API version is 1.44, please upgrade your client to a newer version" location="/root/go/pkg/mod/github.com/chaosblade-io/chaosblade-exec-cri@v1.8.0/exec/executor.go:123" 

[oss-sentinel-ai]

Issue Evaluation

Category: type/enhancement | Status: Evaluated

Feasibility: Moderate - requires dependency upgrade and API compatibility testing.

Scope: Primarily chaosblade-exec-cri (Docker runtime integration).

Assessment:

• Docker 29.0+ requires minimum API version 1.44 (Docker 25.0 used API 1.24)
• The chaosblade-exec-cri module likely uses older Docker client API calls that need updating
• This is a dependency upgrade, not a feature change - the Docker API has been backward-compatible within major versions
• Key areas to check: container exec, network manipulation, and filesystem operations in the CRI executor

Steps Required:

1. Update github.com/docker/docker dependency in chaosblade-exec-cri/go.mod
2. Verify API compatibility for client.ContainerExec*, client.NetworkConnect/Disconnect, and client.CopyToContainer calls
3. Test with Docker 29.0+ runtime

Recommendation: This is a straightforward dependency upgrade. A PR can be generated if the dependency update is approved.

---

Automated evaluation by oss-taishan-ai - ChaosBlade Community Bot

[oss-sentinel-ai]

Code-Level Analysis — Confirmed Root Cause

I have traced the exact code causing this issue in chaosblade-exec-cri.

Root Cause

In exec/container/docker/docker.go, the Docker client is created with a hardcoded API version 1.24:

// exec/container/docker/docker.go, lines 68-70
if endpoint == "" {
    cli, err = client.NewClientWithOpts(client.FromEnv, client.WithVersion("1.24"))
} else {
    cli, err = client.NewClientWithOpts(client.FromEnv, client.WithVersion("1.24"), client.WithHost(endpoint))
}

Docker 29.0+ deprecated and removed support for API versions below 1.44. When the client connects with version 1.24, the Docker daemon immediately rejects the connection with:

client version 1.24 is too old. Minimum supported API version is 1.44

The ping() function attempts version negotiation, but it only handles downgrading (server < client), not upgrading (client < server minimum):

// Only downgrades, never upgrades
if versions.LessThan(p.APIVersion, cli.ClientVersion()) {
    client.WithVersion(p.APIVersion)(cli)
}

Fix

Change the hardcoded version from "1.24" to "1.44" (or use client.WithAPIVersionNegotiation()):

Option A (Simple fix):

// Change "1.24" to "1.44"
cli, err = client.NewClientWithOpts(client.FromEnv, client.WithVersion("1.44"))

Option B (Recommended — use API negotiation):

cli, err = client.NewClientWithOpts(client.FromEnv, client.WithAPIVersionNegotiation())

WithAPIVersionNegotiation() automatically negotiates the correct API version with the Docker daemon, supporting both old and new Docker versions.

Additional Note

The Helm chart daemonset.yaml already sets DOCKER_API_VERSION: "1.44" as an environment variable, but the Go code ignores this and hardcodes "1.24". The fix should also respect the DOCKER_API_VERSION env var.

[woyaonidish]

Plan B /approve