Skip to content

💥 should smarter_id change its format? #73

Description

@bunop

Is your feature request related to a problem? Please describe.
The smarter_id attribute is not a good primary key since it incorporates additional information in its name like country and breed_code. This means that modifing a country or a breed_code for a sample causes inconsistencies between this primary id and fields, having a stable id which contains wrong informations. On the other way, fixing smarter_id relying on new data means that these ids will change with database version.

Describe the solution you'd like
smarter_ids shold be anonymizes, maybe tracking the project name with the number (like SMARTER-OA-000002310, species need to be kept to avoid name collisions between goat and sheep

Describe alternatives you've considered
An alternative could be fix stuff after data import, using a mongoengine query to correct wrong values keeping smarter_id stable. However this means not to trust information in ids anymore.

Additional context
The Galway sheeps breed was tracked as Germany instead of Ireland since country was derived from a wrong set of coordinates. Code and country need to be fixed

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingquestionFurther information is requested

    Type

    No type

    Projects

    Status
    To do

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions