[Feature] Memories factor

[vchatela]

I have searched the existing feature requests to make sure this is not a duplicate request.

• Yes

The feature

Thanks for such great work, I love your app and I use it on many devices.

My proposal is to be able to have a factor of times memories picture is selected versus standard photos from album(s).
As of today, when I have 50+ "today's memories", they almost only runs and I don't get all others standard photos from selected album.

It would be great to be able to select 10% or 5% or 1% of memories to run. So that at every new photo to display, it will decide whether it is a memory or a standard photo to select, based on this factor.

So either memories=false becomes memories=0.2 or you can add an additional parameter to avoid breaking changes.

[damongolding]

What kind of distribution are you seeing?

I ran a quick test with an album of 67 assets and memories totalling 365 assets, and I consistently saw an almost 1:1 match between album assets and memories.

[vchatela]

Hi @damongolding ,
I haven't tested out so I expect about same ratio (0.5 so) as you, but as I have 5k photos in albums and about 30/40 memories per day, I see so many times the same memories and almost never the whole set of my album.

[damongolding]

Ahh ok so you are looking for a way to tweak the balancing of memories. I thought you were having unexpected results and wanted to adjust die to that.

[vchatela]

Exactly, sorry for unclarity 🙂

[damongolding]

@vchatela

So I've added in a penalty to memories which is set via a memory_weight config option. The default for memory_weight is 1 which equates to the normal Kiosk weighting.

You can test the first implementation with this image: ghcr.io/damongolding/immich-kiosk-development:0.30.0-alpha.1

Test of 100 frames with album of 67 assets and 359 memories:
(ratio format is is album_asset:memory_asset)

• memory_weight: 2 = 1:2 ratio
• memory_weight: 1 = 1:1.8 ratio
• memory_weight: 0.5 = 1:0.7 ratio

Test of 100 frames with album of 359 assets and 359 memories:
(ratio format is is album_asset:memory_asset)

• memory_weight: 2 = 1:2.4 ratio
• memory_weight: 1 = 1:0.8 ratio
• memory_weight: 0.5 = 1:0.5 ratio

[vchatela]

Wahou thanks so much! I'll test it when back home tomorrow, can't wait!

[vchatela]

EDIT: using ghcr.io/damongolding/immich-kiosk-development:0.30.0-alpha.1
I've added memory_weight: 0.35 but I get an error that it isn't allowed in the configuration. Any advice ?
Also noticed that the show_image_camera: false isn't supported neither while I see it in the standard config.

[damongolding]

That will be the config validation level (https://docs.immichkiosk.app/configuration/additional-options/#config-validation-level) set it to "warning" while using development builds

[vchatela]

Ok thanks, I've fixed this 👍

11:21:01 WARN Config validation failed:
11:21:01 WARN - (root): Additional property memory_weight is not allowed
11:21:01 WARN - (root): Additional property show_clear_cache_button is not allowed

I'll look at the images now. I don't have the ability to check at my Traefik logs whether the ratio is really what is expected, so I'll let my wife tell me whether she confirms the album ratio is higher than memories

[vchatela]

It looks better from my side (even if I can't confirm the exact rate is enforced).
Thanks a lot !