Replies: 1 comment
|
To be pedantic, the logging uses vaultwarden/src/api/identity.rs Line 579 in 169aa5e vaultwarden/src/db/models/user.rs Lines 244 to 251 in 169aa5e Either way, I don't really believe there is a privacy consideration, since the API key login logs the email every time, and I agree using the email would be a better approach for auditable logs. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Description
Vaultwarden currently logs failed and successful login attempts using different user identifiers.
A failed login is logged as:
A successful login is logged as:
A successful login via API KEY already logs the email, but not the above ones
This makes it difficult to correlate failed and successful authentication events in SIEM platforms, since one event uses the email address while the other uses the display name.
Why this is a problem
From a security monitoring perspective, email addresses are the most stable user identifier.
Display names:
As a result, detecting scenarios such as:
becomes unnecessarily difficult.
Proposed solution
Include both the display name and the email address in successful login events.
For example:
This would preserve the existing display name while providing a stable identifier for security monitoring.
Privacy considerations
If exposing email addresses in logs is considered too sensitive for some deployments, this behaviour could be made configurable, for example:
or enabled only when running with an extended/audit logging mode.
Benefits
Thank you for considering this enhancement.
All reactions