Skip to content

Commit b2e8b40

Browse files
committed
[ci] build the release on JDK 17 and document it
The release workflow set up JDK 11 while the poms compile with source/target 17, so mvn deploy would have failed at compilation with "invalid target release: 17" on the first tag push. CI already uses 17. The READMEs claimed Java 11, which has been wrong since the move to 17: class files are version 61, so an 11 runtime fails with UnsupportedClassVersionError after resolving the dependency rather than at build time.
1 parent 30dce3e commit b2e8b40

4 files changed

Lines changed: 7 additions & 6 deletions

File tree

.github/workflows/release.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,11 @@ jobs:
1111
steps:
1212
- uses: actions/checkout@v4
1313

14-
- name: Set up JDK 11
14+
# Must match maven.compiler.target in the root pom (17), and the CI workflow.
15+
- name: Set up JDK 17
1516
uses: actions/setup-java@v4
1617
with:
17-
java-version: '11'
18+
java-version: '17'
1819
distribution: 'temurin'
1920
cache: maven
2021
server-id: central

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Java client library for the [Gradient Labs API](https://api-docs.gradient-labs.a
1010
- Type-safe models and enums
1111
- Webhook signature verification
1212
- Comprehensive error handling
13-
- Java 11+ compatible
13+
- Java 17+ compatible
1414
- Zero runtime dependencies (except Jackson)
1515

1616
## Spring Boot Integration
@@ -167,7 +167,7 @@ GradientLabsClient client = GradientLabsClient.builder()
167167

168168
## Requirements
169169

170-
- Java 11 or higher
170+
- Java 17 or higher
171171
- Jackson 2.18+ for JSON serialization
172172

173173
## Documentation

gradient-labs-client/examples/spring-boot-example/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ This example demonstrates how to use the Gradient Labs Spring Boot Starter for z
1414

1515
### Prerequisites
1616

17-
- Java 11 or higher
17+
- Java 17 or higher
1818
- Maven
1919
- Gradient Labs API key
2020

gradient-labs-spring-boot-starter/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ The starter includes Spring Boot configuration metadata for IDE autocomplete sup
252252

253253
## Requirements
254254

255-
- Java 11 or higher
255+
- Java 17 or higher
256256
- Spring Boot 3.2.0 or higher
257257
- The core `gradient-labs-client` library (automatically included as a transitive dependency)
258258

0 commit comments

Comments
 (0)