Merge pull request #38 from hartwork/more-test-coverage

gentoo-tree-diff: More test coverage

Author: hartwork

binary_gentoo/internal/cli/tests/test_tree_diff.py

@@ -8,7 +8,56 @@
 from unittest import TestCase
 from unittest.mock import patch
 
-from ..tree_diff import main
+from parameterized import parameterized
+
+from ..tree_diff import (_replace_special_keywords_for_ebuild, enrich_config, main,
+                         parse_command_line)
+
+
+class ReplaceSpecialKeywordsTest(TestCase):
+    @parameterized.expand([
+        ('no ops', {'one', '~two'}, {'three', '~four'}, {'one', '~two'}),
+        ('star op', {'one', '~two', '*'}, {'three', '~four'}, {'one', '~two', 'three'}),
+        ('tilde star op', {'one', '~two', '~*'}, {'three', '~four'}, {'one', '~two', '~four'}),
+        ('double star op', {'one', '~two', '**'}, {'three',
+                                                   '~four'}, {'one', '~two', 'three', '~four'}),
+        ('start op + tilde star op', {'one', '~two', '*',
+                                      '~*'}, {'three', '~four'}, {'one', '~two', 'three',
+                                                                  '~four'}),
+    ])
+    def test(self, _, accept_keywords, ebuild_keywords, expected_effective_keywords):
+        actual_effective_keywords = _replace_special_keywords_for_ebuild(
+            accept_keywords, ebuild_keywords)
+        self.assertEqual(actual_effective_keywords, expected_effective_keywords)
+
+
+class EnrichConfigTest(TestCase):
+    magic_keywords = 'one two ~*'
+
+    @classmethod
+    def _fake_subprocess_check_output(cls, argv):
+        if argv == ['portageq', 'envvar', 'ACCEPT_KEYWORDS']:
+            stdout = cls.magic_keywords
+        else:
+            stdout = f'Hello from: {" ".join(argv)}'
+        return (stdout + '\n').encode('ascii')
+
+    def test_given__empty(self):
+        config = parse_command_line(['gentoo-tree-diff', '--keywords', '', 'dir1', 'dir2'])
+        with self.assertRaises(ValueError):
+            enrich_config(config)
+
+    def test_given__not_empty(self):
+        config = parse_command_line(
+            ['gentoo-tree-diff', '--keywords', 'one    ~two *', 'dir1', 'dir2'])
+        enrich_config(config)
+        self.assertEqual(config.keywords, {'one', 'two', '~two', '*'})
+
+    def test_not_given__auto_detection(self):
+        config = parse_command_line(['gentoo-tree-diff', 'dir1', 'dir2'])
+        with patch('subprocess.check_output', self._fake_subprocess_check_output):
+            enrich_config(config)
+        self.assertEqual(config.keywords, {'one', 'two', '~*'})
 
 
 class MainTest(TestCase):

binary_gentoo/internal/cli/tests/test_tree_sync.py

@@ -0,0 +1,46 @@
+# Copyright (C) 2021 Sebastian Pipping <sebastian@pipping.org>
+# Licensed under GNU Affero GPL version 3 or later
+
+from dataclasses import dataclass
+from subprocess import call
+from tempfile import TemporaryDirectory
+from typing import List
+from unittest import TestCase
+from unittest.mock import patch
+
+from parameterized import parameterized
+
+from ..tree_sync import main
+
+
+@dataclass
+class RunRecord:
+    call_args_list: List["call"]
+
+
+class MainTest(TestCase):
+    @staticmethod
+    def _run_gentoo_tree_sync_with_subprocess_mocked(backup: bool) -> RunRecord:
+        with TemporaryDirectory() as temp_portdir_old,\
+                TemporaryDirectory() as temp_portdir_new:
+            argv = ['gentoo-tree-sync']
+            if backup:
+                argv += ['--backup-to', temp_portdir_old]
+            argv.append(temp_portdir_new)
+
+            with patch('sys.argv', argv), patch('subprocess.check_call') as check_call_mock:
+                main()
+
+            return RunRecord(call_args_list=check_call_mock.call_args_list, )
+
+    @parameterized.expand([
+        ('with backup', True),
+        ('without backup', False),
+    ])
+    def test_success_invokes_docker(self, _, backup: bool):
+        run_record = self._run_gentoo_tree_sync_with_subprocess_mocked(backup=backup)
+
+        docker_run_call = run_record.call_args_list[0]
+        self.assertEqual(docker_run_call.args[0][:2], ['docker', 'run'])
+
+        self.assertEqual(len(run_record.call_args_list), 1)

binary_gentoo/internal/cli/tree_diff.py

@@ -105,7 +105,7 @@ def enrich_config(config):
 
     # add stable keywords for testing keywords
     config.keywords = {kw for kw in config.keywords.split(" ") if kw}
-    config.keywords |= {k[1:] for k in config.keywords if k.startswith('~')}
+    config.keywords |= {k[1:] for k in config.keywords if k.startswith('~') and not k == '~*'}
 
     return config
 

binary_gentoo/internal/cli/tree_sync.py

@@ -103,7 +103,3 @@ def main():
     with exception_reporting():
         config = parse_command_line(sys.argv)
         sync(config)
-
-
-if __name__ == '__main__':
-    main()