Implement: translation-bot-compat

[johnlanni]

Implementation Plan: translation-bot-compat

Delivery Path Decision

Direct implementation by the coordinator agent (single coherent read-side change; no PROCESS coordination needed). Design #453 converged with an independent reviewer verdict SOUND — READY FOR IMPLEMENTATION (4 review rounds, same session). Baseline for all file references: main @ 1156df6 (recorded in Design Current Implementation Locations).

Work Packages and Dependencies

Single work package (one PR): internal/model/translation.go (new) + canonicalization at every enumerated integration point + digest re-basing + write-path canonical comparisons + title normalization + guidance note + tests (Design tests 1–10). Sequential within the package: model first, then consumers, then guards, then tests.

Workspace / Branch Plan

• Local repo: /root/git/issue-spec (origin=higress-group, fork=johnlanni). Branch feat/translation-bot-compat from origin/main, pushed to fork only. PR targets origin/main.

Writer and Provider-review Plan

• Writer: coordinator agent (this session). Independent review by the existing Qoder ACPX session design453-review (same reviewer as Design, per the established review-then-fix loop: review → fix → re-review until both sides converge).
• Implementation steps: build TASK comments on the Implement issue, implement per Design D1–D11, run go test ./..., hand the exact head to the review session, fix findings, converge, then open PR.

Conflict and Serialization Risk

Low: additive model package + local edits at enumerated call sites; no concurrent writers expected on these files.

Provider Checks / Review Status

• Design Issue: 453
• Status: draft

[johnlanni]

Agent: Coordinator
Type: TASK
ID: TASK-454001
Status: confirmed
Scope: Implement #454 translation-bot-compat
Links:

• Proposal Issue: N/A
• Design Issue: N/A
• Implement Issue: N/A
• Related Comments: Implement: translation-bot-compat #454, Proposal: translation-bot-compat #452 (comment)
• PR: N/A

Task: translation-suffix canonical view primitives

Add internal/model/translation.go with the divider allowlist (single lizheming literal, line-anchored), the fence-state-machine guard mirroring preview.Parse (including stop-on-unclosed-fence), the single-divider rule (strip only when exactly one qualifying divider exists), StripTranslationSuffix(body) (string, bool) and CanonicalView(body) string. Strip-only view = StripTranslationSuffix result (no SemanticView masking).

Implementation Checklist

• Create internal/model/translation.go: divider allowlist constant, fence guard, single-divider rule, StripTranslationSuffix, CanonicalView
• Table-test CanonicalView/StripTranslationSuffix per Design test 1: no suffix; suffix at end; suffix duplicating marker + all ## sections; divider with surrounding whitespace; unknown divider (no strip); divider inside ``` fence (kept); divider inside html-preview fence (kept); idempotency; two qualifying dividers (no strip); lone human-authored unfenced divider (stripped, documented edge); empty/odd bodies

Execution Planning

• Owned modules / write areas:
  • internal/model/translation.go
  • internal/model/translation_test.go
• Shared touchpoints:
  • N/A
• Dependency / interface assumptions:
  • N/A
• Coupling class: independent
• Recommended execution mode: serial
• Complexity / split guidance: moderate: fence state machine must mirror preview.Parse regions; single-divider rule interacts with fence guard (qualifying = standalone line + not fenced)

Covers

• SPEC-452001

[johnlanni]

Agent: Coordinator
Type: TASK
ID: TASK-454002
Status: confirmed
Scope: Implement #454 translation-bot-compat
Links:

• Proposal Issue: N/A
• Design Issue: N/A
• Implement Issue: N/A
• Related Comments: Implement: translation-bot-compat #454, Proposal: translation-bot-compat #452 (comment)
• PR: N/A

Task: canonical view at parse and issue-body consumers

Apply canonicalization at every enumerated consumer: (a) inside findMarker and ParseTypedComment (composed view: SemanticView(CanonicalView(body))); (b) inside LogicalBody and TypedSectionList (strip-only view; these do not mask today and must stay passthrough for untranslated preview-containing bodies); (c) directly at validatePhasePredecessor (issue.go:333), locator.go parseMarker/exactPredecessor (157/181), and server canonicalProposalContribution (service.go:421-424).

Implementation Checklist

• findMarker + ParseTypedComment consume SemanticView(CanonicalView(body))
• LogicalBody canonicalizes internally (strip-only view); callers unchanged (question_answer.go 238/257/288-302, process.go 71/185, process_workspace.go 61)
• TypedSectionList canonicalizes internally (strip-only view); covers mutation.go:192 exactly-one gate, index.go 369/381/400, graph.go 83-208, comment.go 696-701
• validatePhasePredecessor, locator.parseMarker/exactPredecessor, canonicalProposalContribution apply CanonicalView before scanning
• Title equality normalization (trailing ' || ' suffix) at bindings/service.go:634-style comparisons
• Tests: Design test 2 (parser equivalence incl. preview-source passthrough), test 3 (issue-body consumers incl. degraded marker copies, genuine duplicate still fails, unclosed-fence fail-closed), test 4 (titles)

Execution Planning

• Owned modules / write areas:
  • internal/model/marker.go
  • internal/model/typed_comment.go
  • internal/model/validation.go
  • internal/model/links.go
  • internal/commands/issue.go
  • internal/change/locator.go
  • internal/server/api/github/issues/service.go
  • internal/server/bindings/service.go
• Shared touchpoints:
  • internal/preview (read-only: fence semantics mirrored, parser unchanged)
• Dependency / interface assumptions:
  • TASK-454001
• Coupling class: shares the translation.go primitives with TASK-454001; no cross-coupling with TASK-454003
• Recommended execution mode: serial after TASK-454001
• Complexity / split guidance: broad but mechanical: many call sites, each a one-line view swap plus tests

Covers

• SPEC-452001

[johnlanni]

Agent: Coordinator
Type: TASK
ID: TASK-454003
Status: confirmed
Scope: Implement #454 translation-bot-compat
Links:

• Proposal Issue: N/A
• Design Issue: N/A
• Implement Issue: N/A
• Related Comments: Implement: translation-bot-compat #454, Proposal: translation-bot-compat #452 (comment)
• PR: N/A

Task: canonical digests and write-path canonical comparisons

Re-base RepresentationDigest on the strip-only view (doc contract rewritten to 'digest of the stripped raw body, no preview masking'; model_test.go:11 replaced), switch the enumerated write-path exact-byte guards to canonical-equality comparisons with canonical-digest messages, add the divider boundary to relationship semantic scans (D9: within-prefix duplicates still ErrAmbiguous), and document residuals (D10 version-CAS, D2 sealed-digest migration, ANSWER edited-evidence fail-closed).

Implementation Checklist

• RepresentationDigest hashes StripTranslationSuffix(body); doc comment rewritten; model_test.go:11 contract test replaced
• engine.go 570/588/638/653 and link.go 313/335/347 compare canonical views/digests; 'exact' message strings reworded to 'canonical'; link.go:335 passes on suffix-only drift, aborts on canonical drift
• Relationship scans (PlanMutation/ApplyMutation/removeSemanticAuthority) bounded at the divider: suffix matches excluded, within-prefix duplicates still ErrAmbiguous (mutation.go:354-356), raw-line index arithmetic unchanged
• Generated skill guidance note: translation suffixes tolerated, never hand-strip, never author the divider literal outside fenced blocks
• Tests: Design test 5 (digest stability + preview-only edit visible), test 7 (server/runner surfaces), test 8 (write-path guards incl. simulated suffix append post-write; no identical-digest mismatch messages), test 9 (relationship boundary: no duplicate graph edges, index totals unchanged, within-prefix duplicate still ErrAmbiguous), test 10 (sealed ANSWER + bot translation: digest stable, ResolveEffectiveAnswers still rejects)

Execution Planning

• Owned modules / write areas:
  • internal/model/typed_comment.go (RepresentationDigest)
  • internal/reconcile/engine.go
  • internal/commands/link.go
  • internal/relationships/mutation.go
  • .agents/skills templates
• Shared touchpoints:
  • digest sites in internal/finalization, internal/durable, internal/commentrunner recompute via the same helper
• Dependency / interface assumptions:
  • TASK-454001
  • TASK-454002
• Coupling class: depends on both prior TASKs; digest sites are mechanical re-basing once the helper exists
• Recommended execution mode: serial after TASK-454002
• Complexity / split guidance: moderate: the comparison-site edits are small but must each preserve guarantee semantics (strict-conditional vs non-atomic paths)

Covers

• SPEC-452001

[johnlanni]

Implementation merged via PR #455 (squash 1bc29fe). TASK-454001/454002/454003 all complete; two rounds of independent qoder-k3 review APPROVE; CI green.