refactor: update constructors to use PageObject directly for better context handling

Author: akash-manna-sky

src/main/java/org/jenkinsci/test/acceptance/plugins/disk_usage/DiskUsage.java

@@ -31,7 +31,7 @@
 @PluginPageObject("disk-usage")
 public class DiskUsage extends PageObject {
 
-    public DiskUsage(Injector i, URL url) {
+    public DiskUsage(PageObject i, URL url) {
         super(i, url);
     }
 

src/main/java/org/jenkinsci/test/acceptance/plugins/gerrit_trigger/GerritTriggerJob.java

@@ -59,7 +59,7 @@ public class GerritTriggerJob extends PageObject {
             "/com-sonyericsson-hudson-plugins-gerrit-trigger-hudsontrigger-GerritTrigger/triggerOnEvents/commentAddedTriggerApprovalValue");
 
     public GerritTriggerJob(Jenkins jenkins, String jobName) {
-        super(jenkins.injector, jenkins.url("job/" + jobName + "/configure"));
+        super(jenkins, jenkins.url("job/" + jobName + "/configure"));
         this.jenkins = jenkins;
     }
 

src/main/java/org/jenkinsci/test/acceptance/plugins/gerrit_trigger/GerritTriggerNewServer.java

@@ -38,7 +38,7 @@ public class GerritTriggerNewServer extends PageObject {
     public final Control modeDefault = control("/mode[com.sonyericsson.hudson.plugins.gerrit.trigger.GerritServer]");
 
     public GerritTriggerNewServer(Jenkins jenkins) {
-        super(jenkins.injector, jenkins.url("gerrit-trigger/newServer"));
+        super(jenkins, jenkins.url("gerrit-trigger/newServer"));
         this.jenkins = jenkins;
     }
 

src/main/java/org/jenkinsci/test/acceptance/plugins/gerrit_trigger/GerritTriggerServer.java

@@ -59,7 +59,7 @@ public class GerritTriggerServer extends PageObject {
     private static final String serverUrl = "gerrit-trigger/server/";
 
     public GerritTriggerServer(Jenkins jenkins, String serverName) {
-        super(jenkins.injector, jenkins.url(serverUrl + serverName));
+        super(jenkins, jenkins.url(serverUrl + serverName));
         this.jenkins = jenkins;
     }
 

src/main/java/org/jenkinsci/test/acceptance/po/Artifact.java

@@ -19,7 +19,7 @@ public class Artifact extends PageObject {
     private final @NonNull String path;
 
     public Artifact(@NonNull Build build, @NonNull String path) {
-        super(build.injector, build.url("artifact/%s", path));
+        super(build, build.url("artifact/%s", path));
         this.build = build;
         this.path = path;
     }

src/main/java/org/jenkinsci/test/acceptance/po/BuildHistory.java

@@ -16,11 +16,11 @@ public class BuildHistory extends PageObject {
     private static final Pattern CONSOLE_LINK_PATTERN = Pattern.compile("/job/(.+?)/(\\d+)/console");
 
     public BuildHistory(Node parent) {
-        super(parent.injector, parent.url("builds"));
+        super(parent, parent.url("builds"));
     }
 
     public BuildHistory(View parent) {
-        super(parent.injector, parent.url("builds"));
+        super(parent, parent.url("builds"));
     }
 
     public Set<Build> getBuilds() {

src/main/java/org/jenkinsci/test/acceptance/po/PageObject.java

@@ -47,6 +47,11 @@ public abstract class PageObject extends CapybaraPortingLayerImpl {
 
     private static final RandomNameGenerator RND = new RandomNameGenerator();
 
+    /**
+     * @deprecated Use {@link #PageObject(PageObject, URL)} instead to preserve per-test context.
+     * Classes extending PageObject should pass the parent context to maintain proper test context.
+     */
+    @Deprecated
     public PageObject(Injector injector, URL url) {
         super(injector);
         this.url = url;

src/main/java/org/jenkinsci/test/acceptance/po/WizardCreateAdminUser.java

@@ -49,7 +49,7 @@ public class WizardCreateAdminUser extends PageObject {
     JenkinsController controller;
 
     public WizardCreateAdminUser(Jenkins jenkins) {
-        super(jenkins.injector, jenkins.url(""));
+        super(jenkins, jenkins.url(""));
     }
 
     public WizardCreateAdminUser createAdminUser(String userName, String password, String fullName, String email) {

src/main/java/org/jenkinsci/test/acceptance/po/WizardLogin.java

@@ -47,7 +47,7 @@ public class WizardLogin extends PageObject {
     private Control cLogin = control("/Continue");
 
     public WizardLogin(Jenkins jenkins) {
-        super(jenkins.injector, jenkins.url(""));
+        super(jenkins, jenkins.url(""));
     }
 
     /**

src/main/java/org/jenkinsci/test/acceptance/utils/pluginTests/SecurityDisabler.java

@@ -35,7 +35,7 @@ public class SecurityDisabler extends PageObject {
     public final Jenkins jenkins;
 
     public SecurityDisabler(Jenkins jenkins) {
-        super(jenkins.injector, jenkins.url("configureSecurity"));
+        super(jenkins, jenkins.url("configureSecurity"));
         this.jenkins = jenkins;
     }