docs: fix RedisCacheStore → RedisStore in example comments - #8066
Open
Siddhesh Kabra (Xsidz) wants to merge 3 commits into
Open
docs: fix RedisCacheStore → RedisStore in example comments#8066Siddhesh Kabra (Xsidz) wants to merge 3 commits into
Siddhesh Kabra (Xsidz) wants to merge 3 commits into
Conversation
Fixes microsoft#7084 RedisCacheStore does not exist; the correct class is RedisStore. Corrected in three example code comments across the migration guide, core model-clients notebook, and the ChatCompletionCache docstring.
Contributor
|
Siddhesh Kabra (@Xsidz) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7084
RedisCacheStoreis not a real class — the correct name isRedisStore(fromautogen_ext.cache_store.redis). The wrong name appeared as a comment in three example code blocks.Files changed:
python/packages/autogen-ext/src/autogen_ext/models/cache/_chat_completion_cache.py— docstring examplepython/docs/src/user-guide/agentchat-user-guide/migration-guide.md— migration guide examplepython/docs/src/user-guide/core-user-guide/components/model-clients.ipynb— model clients notebookAll three were comments showing Redis as an alternative to DiskCache, so no runtime behavior changes.
Test plan
grep -rn "RedisCacheStore"returns nothing after the fixRedisStoreis the actual class inautogen_ext/cache_store/redis.py