Skip to content

Commit c207d07

Browse files
EliMoshkovichclaude
andcommitted
Upgrade CI Helm version and revert unnecessary template changes
The helm lint failures in CI were caused by using outdated Helm 3.3.4 (from 2020). The template syntax `ne .Values.server.enabled false` works correctly with modern Helm versions. Changes: - Upgraded CI Helm version from 3.3.4 to 3.19.0 (latest stable) - Reverted commit b82a8f2 template changes (not needed with modern Helm) Testing confirmed: - All helm lint tests pass with Helm 3.14+ and 3.19.0 - Customer issue (empty dataConfigSources entries) remains fixed - Original template syntax is compatible with modern Helm 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent b82a8f2 commit c207d07

5 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/master.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- uses: actions/checkout@v2
1717
- uses: azure/setup-helm@v1
1818
with:
19-
version: "3.3.4"
19+
version: "3.19.0"
2020
- name: helm lint
2121
run: |
2222
jq --version

templates/deployment-client.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{{- if .Values.client }}
2-
{{- if ne (.Values.client.enabled | default true) false }}
2+
{{- if ne .Values.client.enabled false }}
33
{{- $nm := include "opal.clientName" . | quote }}
44
apiVersion: apps/v1
55
kind: Deployment

templates/deployment-server.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{{- if .Values.server }}
2-
{{- if ne (.Values.server.enabled | default true) false }}
2+
{{- if ne .Values.server.enabled false }}
33
{{- $nm := include "opal.serverName" . | quote }}
44
apiVersion: apps/v1
55
kind: Deployment

templates/service-client.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{{- if .Values.client }}
2-
{{- if ne (.Values.client.enabled | default true) false }}
2+
{{- if ne .Values.client.enabled false }}
33
apiVersion: v1
44
kind: Service
55
metadata:

templates/service-server.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{{- if .Values.server }}
2-
{{- if ne (.Values.server.enabled | default true) false }}
2+
{{- if ne .Values.server.enabled false }}
33
apiVersion: v1
44
kind: Service
55
metadata:

0 commit comments

Comments
 (0)