Pull Request by Zilin Huang regarding Issue #221 - #228
Closed
huangz73 wants to merge 19 commits into
Closed
Conversation
Author
|
|
ddsjoberg
reviewed
Oct 21, 2024
| } | ||
| if (any(!outcome %in% unique(df$outcome))) { | ||
| cli_abort("Argument {.code outcome} must be one or more of {.val {unique(df$outcome)}}") | ||
| cli_abort("Argument {.arg x} does not support {.cls survfit.coxphms} object.") |
Collaborator
There was a problem hiding this comment.
I don't understand this change to the error message. Was this intentional?
Author
There was a problem hiding this comment.
@ddsjoberg apologize that I may make this change by mistake. I have changed this section back to its original version (with "Argument {.code outcome}")
Collaborator
|
hey @ddsjoberg main issue for the failing check in this PR seems to be an older version of Ubuntu - i think it needs to be updated to: ubuntu-22.04 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #221 by modifying the
utils-add_risktable()function for duplicated x-axis case.