Receiving stale values for conditional dependents in atom read

[probeiuscorp]

In certain circumstances atoms with conditional dependents may receive stale values for those dependents.

I was able to reproduce the issue (not easily!) and have made a test case.

A few notes:

• Moving const filtered = get(filteredAtom) up before the if in stageAtom's read avoids the bug
  • This is how I've mitigated this bug in my own code
• Subscribing to both stageAtom and filteredAtom is necessary to reproduce the bug

This is a regression since 59e04ab. In my testing store2 passes.

[dai-shi]

Nice catch.

In my testing store2 passes.

Do you mean, store.ts fails while store2.ts passes? That's great to know.
Please open a PR with this condition: it.skipIf(!import.meta.env?.USE_STORE2)(...)

Example: https://github.com/pmndrs/jotai/pull/2533/files#diff-d32cc71c13ecc7fc7879c5f6bd5a11066daa3e2b351fd23668fcf8d9438911cbR29

[probeiuscorp]

I didn't try the test case with those exact conditions, so I can't say for sure, but I built jotai/experimental and it worked for my application code like v2.6.3 did. I'll be opening a PR soon.

[dai-shi]

Sounds good.

[probeiuscorp]

PR is in!

[dai-shi]

I didn't try the test case with those exact conditions, so I can't say for sure, but I built jotai/experimental and it worked for my application code like v2.6.3 did. I'll be opening a PR soon.

#2534 (comment) Can you confirm if it works with jotai/experimental again? The test doesn't seem to pass. If it's the case, our approach might change.

[probeiuscorp]

Since that comment I have forgotten what I did to use jotai/experimental. Could you remind me?

[dai-shi]

Something like this:

import { createStore } from 'jotai/experimental';
import { Provider } from 'jotai/react';

const store = createStore();

const MyProvider = ({ children }) => <Provider store={store}>{children}</Provider>;

[probeiuscorp]

In hindsight I definitely should've tried that. Yes, for me jotai/experimental did not pass the test either. Sorry for the wrong info.