Problem
just gate cannot complete on current stable. cargo clippy --all-targets --all-features -- -D warnings stops at src/icloud/photos/queries.rs:242:
error: consider using `sort_unstable_by_key`
--> src/icloud/photos/queries.rs:242:5
|
242 | pairs.sort_unstable_by(|(left_key, _), (right_key, _)| left_key.cmp(right_key));
clippy::unnecessary_sort_by fires on 1.97.1 and does not fire on the 1.94.1 pinned by RUST_STABLE_TOOLCHAIN in .github/workflows/ci.yml, so CI is unaffected and this is purely a local blocker.
Impact
just gate halts at its first static phase, hiding every later phase. Anyone running the documented pre-push gate on a current stable toolchain sees a failure unrelated to their branch and has to run the remaining phases by hand, or discover that RUSTUP_TOOLCHAIN=1.94.1 is needed.
Expected behaviour
just gate passes on both the pinned toolchain and current stable, or the toolchain expectation is stated where the gate is documented.
The lint's own suggestion applies cleanly:
pairs.sort_unstable_by_key(|(key, _)| *key);
Keying the sort also states the intent directly: ordering depends on the parameter name and never on the value.
Raised separately rather than folded into a feature branch, since it touches a file no current feature needs.
Problem
just gatecannot complete on current stable.cargo clippy --all-targets --all-features -- -D warningsstops atsrc/icloud/photos/queries.rs:242:clippy::unnecessary_sort_byfires on 1.97.1 and does not fire on the 1.94.1 pinned byRUST_STABLE_TOOLCHAINin.github/workflows/ci.yml, so CI is unaffected and this is purely a local blocker.Impact
just gatehalts at its first static phase, hiding every later phase. Anyone running the documented pre-push gate on a current stable toolchain sees a failure unrelated to their branch and has to run the remaining phases by hand, or discover thatRUSTUP_TOOLCHAIN=1.94.1is needed.Expected behaviour
just gatepasses on both the pinned toolchain and current stable, or the toolchain expectation is stated where the gate is documented.The lint's own suggestion applies cleanly:
Keying the sort also states the intent directly: ordering depends on the parameter name and never on the value.
Raised separately rather than folded into a feature branch, since it touches a file no current feature needs.