some minor updates

Author: Rider-Linden

Sources.cmake

@@ -352,6 +352,7 @@ target_sources(Luau.VM PRIVATE
     VM/include/luaconf.h
     VM/include/lualib.h
     VM/include/llsl.h
+    VM/include/llfluent_builder.h
 
     VM/src/ares.cpp
     VM/src/lapi.cpp
@@ -430,7 +431,6 @@ target_sources(Luau.VM PRIVATE
     VM/src/llprim.h
     VM/src/llprim_set_primitive_params.inl
     VM/src/llfluent_builder.cpp
-    VM/include/llfluent_builder.h
     VM/src/lyieldable.cpp
     VM/src/lstrbuf.cpp
     VM/src/lyieldstrlib.h

VM/include/llfluent_builder.h

@@ -7,6 +7,21 @@ typedef int (*lua_CFunction)(lua_State* L);
 // Default link target: apply to the prim running the script.
 static const int SLUA_LINK_THIS = -4;
 
+// A note about C++20 porting.
+// The const char* name fields in the descriptors must have static storage duration 
+// (e.g. string literals).
+// This is not enforced at compile time,
+// but when moving to C++20 we can do something like the following:
+//
+// struct LiteralString
+// {
+//    consteval LiteralString(const char* p) noexcept : ptr(p) {}
+//    operator const char*() const noexcept { return ptr; }
+//    const char* ptr;
+// };
+// The consteval constructor ensures that only string literals can be used 
+// to construct a LiteralString.
+
 struct FluentParamDescriptor
 {
     const char* name;     // effective property name (pretty alias or strict fallback)