[mod] Remove legacy pack format stuff

Author: ptaoussanis

src/taoensso/sente.cljc

@@ -206,94 +206,31 @@
 ;; * Client<->server payloads are arbitrary Clojure vals (cb replies or events).
 ;; * Payloads are packed for client<->server transit.
 
-(defn- parse-packed
-  "Returns [<packed> <?format>]. Used to support some minimal backwards
-  compatibility between v2 `pack` and v1 `unpack`."
-  ;; TODO Remove this in a future ~breaking release
-  [packed]
-  (if (string? packed)
-    (cond
-      (enc/str-starts-with? packed "+") [(subs packed 1) :v1/wrapped]
-      (enc/str-starts-with? packed "-") [(subs packed 1) :v1/unwrapped]
-      :else                             [      packed    :v2/unwrapped])
-    [packed :v2/unwrapped]))
-
-(comment (parse-packed "+[[\"foo\"] \"uuid\"]"))
-
 (defn- unpack "packed->[clj ?cb-uuid]"
   [packer packed]
-  (let [[packed ?format] (parse-packed packed)
-        unpacked ; [clj ?cb-uuid]
+  (let [[clj ?cb-uuid]
         (try
           (interfaces/unpack packer packed)
           (catch #?(:clj Throwable :cljs :default) t
             (timbre/errorf t "Failed to unpack: %s" packed)
             [[:chsk/bad-package packed] nil]))
 
-        [clj ?cb-uuid]
-        (case ?format
-          :v1/wrapped    unpacked
-          :v1/unwrapped [unpacked nil]
-          :v2/unwrapped  unpacked)
-
         ?cb-uuid (if (= 0 ?cb-uuid) :ajax-cb ?cb-uuid)]
 
     [clj ?cb-uuid]))
 
-(def ^:dynamic *write-legacy-pack-format?*
-  "Advanced option, most users can ignore this var. Only necessary
-  for those that want to use Sente < v1.18 with a non-standard
-  IPacker that deals with non-string payloads.
-
-  Details:
-    Sente uses a private message format as an implementation detail
-    for client<->server comms.
-
-    As part of [#398], this format is being updated to support
-    non-string (e.g. binary) payloads.
-
-    Unfortunately updating the format is non-trivial because:
-      1. Both the client & server need to support the same format.
-      2. Clients are often served as cached cl/js.
-
-    To help ease migration, the new pack format is being rolled out
-    in stages:
-
-      Sente <= v1.16: reads  v1 format only
-                      writes v1 format only
-
-      Sente    v1.17: reads  v1 and v2 formats
-                      writes v1 and v2 formats (v1 default)
-
-      Sente    v1.18: reads  v1 and v2 formats
-                      writes v1 and v2 formats (v2 default)  <- Currently here
-
-      Sente >= v1.19: reads  v2 format only
-                      writes v2 format only
-
-    This var controls which format to use for writing.
-    Override default with `alter-var-root` or `binding`."
-
-  false)
-
 (defn- pack "[clj ?cb-uuid]->packed"
   ([packer clj         ] (pack packer clj nil))
   ([packer clj ?cb-uuid]
-   (let [?cb-uuid (if (= ?cb-uuid :ajax-cb) 0 ?cb-uuid)
-         packed
-         (interfaces/pack packer
-           (if-some [cb-uuid ?cb-uuid]
-             [clj cb-uuid]
-             [clj        ]))]
-
-     (if *write-legacy-pack-format?*
-       (str "+" (have string? packed))
-       (do                    packed)))))
+   (let [?cb-uuid (if (= ?cb-uuid :ajax-cb) 0 ?cb-uuid)]
+     (interfaces/pack packer
+       (if-some [cb-uuid ?cb-uuid]
+         [clj cb-uuid]
+         [clj        ])))))
 
 (comment
   (unpack default-edn-packer
-    (binding [*write-legacy-pack-format?* true]
-      (pack default-edn-packer [:foo]))))
+    (pack default-edn-packer [:foo])))
 
 (deftype EdnPacker []
   interfaces/IPacker

src/taoensso/sente/interfaces.cljc

@@ -54,10 +54,6 @@
 
 (defprotocol IPacker
   "Extension pt. for client<->server comms data un/packers:
-  arbitrary Clojure data <-> serialized payloads.
-
-  NB if dealing with non-string payloads, see also
-  `taoensso.sente/*write-legacy-pack-format?*`."
-
+  arbitrary Clojure data <-> serialized payloads."
   (pack   [_ x])
   (unpack [_ x]))