Skip to content

Rotated workspace cache follow-ups from the #543 review: config latch into the cached KSP (m1), enumeration reuse by coincidence (m3) #546

Description

@lmoresi

Two non-blocking findings from the #543 adversarial review of the rotated-workspace reuse (full detail in the review comment there):

  1. m1solver.tolerance and a custom-FMG registration latch into the cached KSP at ctx creation. A later tightening is still honoured on the true residual (measured 1e-4 → 1e-10, err 1.8e-11) but via extra outer increments, with the inner-margin discipline silently violated. The cache key (or the ctx) should observe the tolerance/FMG configuration and rebuild the KSP when it changes.
  2. m3 — the coefficient-variable enumeration is reused on geometry match alone; today this is safe only because every dependency-changing route forces a full _build teardown — a coincidence inherited from aux-layout invalidation, not enforced by the cache. Re-derive the enumeration on JIT-key mismatch so the safety is by construction.

Underworld development team with AI support from Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions