Incremental PV backup for AWS and GCP

[chrislinan]

Hi, I know there is already a support of incremental snapshot for Azure at here

But I want to know if the incremental snapshot is also implemented for AWS and GCP? Because I can't see the "incremental" parameter in this AWS function, is that supported by default, or configurable as the same with Azure?

Also, Is there a command line parameter to specify the backup is full or incremental?
for example: Velero backup create --include-namespace default --include-resource pv,pvc --incremental ?

Thanks a lot.

[blackpiglet]

https://cloud.google.com/compute/docs/disks/snapshots?hl=en#incremental-snapshots
https://docs.aws.amazon.com/ebs/latest/userguide/ebs-snapshots.html

Both the AWS EBS snapshot and the GCP disk snapshot enable the incremental feature by default.
That's why there are no such configurations in the GCP and the AWS plugins.

Please note that the providers handle the incremental snapshots. Velero itself doesn't know.

[chrislinan]

Hi @blackpiglet Thanks for your answer, I have another question about the snapshot completion:
In Azure plugin, here is a poller to wait for the snapshot complete:

	pollerResp, err := b.snaps.BeginCreateOrUpdate(ctx, b.snapsResourceGroup, *snap.Name, snap, nil)
	if err != nil {
		return "", errors.WithStack(err)
	}
	_, err = pollerResp.PollUntilDone(ctx, &azruntime.PollUntilDoneOptions{Frequency: pollingDelay})
	if err != nil {
		return "", errors.WithStack(err)
	}

But AWS don't have such poller, the implementation in AWS plugin will not wait for the asynchronous process complete, it will return directly:

res, err := b.ec2.CreateSnapshot(context.Background(), &ec2.CreateSnapshotInput{
		VolumeId: &volumeID,
		TagSpecifications: []types.TagSpecification{
			{
				ResourceType: types.ResourceTypeSnapshot,
				Tags:         getTags(tags, volumeInfo.Tags),
			},
		},
	})
	if err != nil {
		return "", errors.WithStack(err)
	}

	return *res.SnapshotId, nil

The GCP implementation is the same with AWS, it's not waiting for the asynchronous process complete.

I want to know, Can we add the wait mechanism also for AWS and GCP plugin? Just as the same with Azure.

Thanks a lot.

[blackpiglet]

I checked the AWS and GCP SDKs. They didn't provide similar functions to the Azure SDK, but theoretically, we can achieve that by polling the snapshot status until it's ready.

But the Velero native snapshot using the provider volume snapshotter plugins is not the focus now. We are actively working on the CSI snapshot data mover, so we may not have enough bandwidth to pick up this enhancement lately.

But any PRs from the community are welcome.