Remove makefile support from mom5 and use tag-based versions by harshula · Pull Request #443 · ACCESS-NRI/access-spack-packages

harshula · 2026-06-16T11:17:02Z

Motivation

We have an opportunity to remove support for the legacy build systems of access-mocsy and mom5 before the ACCESS-ESM1.6 Release.
Use tag-based spack versions for all packages ACCESS-ESM1.6#180

Caveat

If we need to backport a bug fix for gcom4 or um7 for ACCESS-ESM1.5, we could create a new branch api-v2-esm1.5 that branches off the commit just before the commit containing this PR's merge.

Pre-merge actions

Update the access-spack-packages tag mentioned in the source files. e.g., "access-esm1.5 is only available in access-spack-packages tagged 2026.07.010 and older."

Component Repository CI manifest fixes.

Post-merge actions

Update: https://github.com/search?q=org%3AACCESS-NRI+%28%3Daccess-om2+OR+%3Daccess-esm1.6%29+NOT+%28model%3Daccess-om2+OR+model%3Daccess-esm1.6%29&type=code
gcom4/um7 repository CI manifests have to use real versions.
spack.yaml: use real versions ACCESS-OM2#154
spack.yaml: use real versions ACCESS-ESM1.6#212
[no ci] spack.yaml: add a warning with valid mom5 versions ACCESS-ESM1.5#51

…/access-spack-packages#443

…RI/access-spack-packages#443 (#99)

harshula · 2026-06-23T09:54:37Z

The blocker for this PR is that https://github.com/ACCESS-NRI/ACCESS-ESM1.5 (https://github.com/ACCESS-NRI/ACCESS-ESM1.5/blob/f2572827861803b9a9165821d4a7e96d9566c515/spack.yaml#L17-L19) uses the following MOM5 branch:

access-spack-packages/spack_repo/access/nri/packages/mom5/package.py

Line 29 in 88271e7

version("access-esm1.5", branch="access-esm1.5")

and that branch (https://github.com/ACCESS-NRI/MOM5/tree/access-esm1.5) does not contain a CMake build system.

harshula · 2026-06-23T10:51:35Z

To unblock this PR, could we put a comment stating only use up to X (e.g. 2026.06.004) version of access-spack-packages above https://github.com/ACCESS-NRI/ACCESS-ESM1.5/blob/f2572827861803b9a9165821d4a7e96d9566c515/config/versions.json#L4 .

dougiesquire · 2026-06-24T06:18:24Z

To unblock this PR, could we put a comment stating only use up to X (e.g. 2026.06.004) version of access-spack-packages above https://github.com/ACCESS-NRI/ACCESS-ESM1.5/blob/f2572827861803b9a9165821d4a7e96d9566c515/config/versions.json#L4 .

I'll wait for @aidanheerdegen to confirm he's fine with this before reviewing

aidanheerdegen · 2026-06-25T01:24:38Z

I am fine with this as long as it is still possible for a user to take the ACCESS-ESM1.5 deployment spack.yaml and build it on gadi and make minor code changes. This would necessarily be limited to the versions of dependencies pinned at the point of this change, but I think that is fine.

This gets a bit more complex when we move to a new HPC. At that point we'd need to decide if ESM1.5 was going to be supported on the new architecture, and if so we would need to look at the work required to do so. But I think it is fine wait and see and make a decision then.

dougiesquire

Thanks @harshula

harshula · 2026-06-27T15:47:53Z

This PR should be merged after Issue #446 is fixed and merged.

* Add version 2026.02.000

* Add version 2025.08.000.

* cice4 is a dependency of only access-esm1.5. * access-esm1.5 will not be buildable after Makefile support is removed from the MOM5 SPR.

* Claude Opus 5 suggested the comment update.

* Dougie Squire suggested constraining versioning.

dougiesquire

Thanks @harshula, looking good!

* Dougie Squire suggested adding a msg to the conflicts().

* Add version stable and tag-based versions * Add a version that corresponds to the um7 version used in ACCESS-ESM1.5.

* Tommy Gatti suggested adding a conflict() to prevent building access-esm1.5, instead of deleting the SBR from the repository.

* Suggested by Aidan Heerdegen.

dougiesquire

Thanks @harshula.

I think we need to replace the =access-esm1.5 with =stable in the gcom4 build-ci manifests?

Similarly for um7 build-ci manifests. Looks like the oasis3-mct version should be updated in these also.

harshula · 2026-08-05T11:23:31Z

Hi @dougiesquire ,

I think we need to replace the =access-esm1.5 with =stable in the gcom4 build-ci manifests?

Similarly for um7 build-ci manifests.

Already documented in the PR description.

dougiesquire · 2026-08-05T11:28:27Z

Already documented in the PR description.

Sorry, missed that. Is there a reason why these are to be done after merge but the equivalent in MOM5, libaccessom2 and oasis3-mct were done before?

harshula · 2026-08-05T12:11:22Z

Hi @dougiesquire ,

Sorry, missed that. Is there a reason why these are to be done after merge but the equivalent in MOM5, libaccessom2 and oasis3-mct were done before?

This PR is blocker for the ACCESS-ESM1.6 release and I would prefer not to keep completing tasks that should be completed by others.

dougiesquire

Roger. Thanks for all your work on this

harshula self-assigned this Jun 16, 2026

harshula added this to ACCESS-ESM1.6, Model Release and ACCESS-NRI Infrastructure Jun 16, 2026

github-project-automation Bot moved this to New Issues 🌅 in Model Release Jun 16, 2026

anton-seaice mentioned this pull request Jun 17, 2026

Deprecate makefile build ACCESS-NRI/cice5#98

Closed

harshula force-pushed the cleanup-before-esm1.6-release branch from 4c9a302 to 4d07b33 Compare June 18, 2026 07:09

harshula changed the title ~~Remove makefile support from cice5 and mom5~~ Remove makefile support from access-mocsy and mom5 Jun 18, 2026

anton-seaice added a commit to ACCESS-NRI/cice5 that referenced this pull request Jun 22, 2026

Remove makefile builds from spack manifests / build-CI per ACCESS-NRI…

22aef74

…/access-spack-packages#443

anton-seaice added a commit to ACCESS-NRI/cice5 that referenced this pull request Jun 22, 2026

* Remove makefile builds from spack manifests / build-CI per ACCESS-N…

31f3844

…RI/access-spack-packages#443 (#99)

harshula force-pushed the cleanup-before-esm1.6-release branch from be19aa5 to 8889c48 Compare June 22, 2026 07:58

harshula changed the title ~~Remove makefile support from access-mocsy and mom5~~ Remove makefile support from mom5 Jun 22, 2026

harshula requested review from aidanheerdegen, anton-seaice, blimlim and dougiesquire June 23, 2026 10:51

harshula marked this pull request as ready for review June 23, 2026 10:53

anton-seaice removed their request for review June 25, 2026 03:19

dougiesquire reviewed Jun 26, 2026

View reviewed changes

Comment thread spack_repo/access/nri/packages/mom5/package.py Outdated

Comment thread spack_repo/access/nri/packages/mom5/package.py Outdated

harshula requested a review from dougiesquire June 29, 2026 06:25

dougiesquire reviewed Jun 29, 2026

View reviewed changes

Comment thread spack_repo/access/nri/packages/mom5/package.py

harshula force-pushed the cleanup-before-esm1.6-release branch from c7a9a8a to b3e085b Compare July 6, 2026 03:05

harshula mentioned this pull request Jul 6, 2026

build-ci/manifests/scheduled: remove makefile tests ACCESS-NRI/MOM5#82

Merged

harshula force-pushed the cleanup-before-esm1.6-release branch 2 times, most recently from 641ad99 to 604f274 Compare July 7, 2026 04:15

harshula added 5 commits August 4, 2026 16:35

libaccessom2: version access-om2 replaced by stable

305ac3f

* Add version 2026.02.000

access-fms: version main is replaced by stable

a7c07b8

* Add version 2025.08.000.

build-ci/data/exclude.json: exclude cice4

dda5eb9

* cice4 is a dependency of only access-esm1.5. * access-esm1.5 will not be buildable after Makefile support is removed from the MOM5 SPR.

access-generic-tracers: delete version main

7891438

* Claude Opus 5 suggested the comment update.

oasis3-mct: add version 2025.03.001 and delete version access-om2

d71a77a

* Dougie Squire suggested constraining versioning.

harshula dismissed aidanheerdegen’s stale review via bcd37cd August 4, 2026 06:59

harshula force-pushed the cleanup-before-esm1.6-release branch from cea2b28 to bcd37cd Compare August 4, 2026 06:59

harshula requested a review from aidanheerdegen August 4, 2026 07:03

This was referenced Aug 5, 2026

Add new version CICE6.6.3-2 #470

Merged

Add WW3 2026.03.001 #471

Merged

dougiesquire reviewed Aug 5, 2026

View reviewed changes

Comment thread spack_repo/access/nri/packages/gcom4/package.py Outdated

Comment thread spack_repo/access/nri/packages/gcom4/package.py

harshula added 3 commits August 5, 2026 14:53

gcom4: delete version access-esm1.5 , add tag-based versions

6681968

* Dougie Squire suggested adding a msg to the conflicts().

um7: delete versions access-esm1.5 and access-esm1.6

95485c4

* Add version stable and tag-based versions * Add a version that corresponds to the um7 version used in ACCESS-ESM1.5.

access-esm1.6: use real versions and deprecate access-esm1.5

615d210

* Tommy Gatti suggested adding a conflict() to prevent building access-esm1.5, instead of deleting the SBR from the repository.

harshula force-pushed the cleanup-before-esm1.6-release branch from bcd37cd to 91c56c2 Compare August 5, 2026 05:29

harshula requested a review from dougiesquire August 5, 2026 05:31

cice4: deprecated

439f787

* Suggested by Aidan Heerdegen.

harshula force-pushed the cleanup-before-esm1.6-release branch from 91c56c2 to 439f787 Compare August 5, 2026 06:12

dougiesquire reviewed Aug 5, 2026

View reviewed changes

harshula requested a review from dougiesquire August 5, 2026 11:24

dougiesquire approved these changes Aug 5, 2026

View reviewed changes

harshula merged commit e3330a8 into api-v2 Aug 6, 2026
46 of 50 checks passed

github-project-automation Bot moved this to Done in ACCESS-ESM1.6 Aug 6, 2026

github-project-automation Bot moved this to Done in ACCESS-NRI Infrastructure Aug 6, 2026

github-project-automation Bot moved this from New Issues 🌅 to Done ✅ in Model Release Aug 6, 2026

harshula deleted the cleanup-before-esm1.6-release branch August 6, 2026 00:23

CodeGat mentioned this pull request Aug 7, 2026

Model Components Using Non-@git.REFs are not parsable by Release Database Upload ACCESS-NRI/build-cd#419

Open

Uh oh!

Conversation

harshula commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Caveat

Pre-merge actions

Component Repository CI manifest fixes.

Post-merge actions

Uh oh!

harshula commented Jun 23, 2026

Uh oh!

harshula commented Jun 23, 2026

Uh oh!

dougiesquire commented Jun 24, 2026

Uh oh!

aidanheerdegen commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dougiesquire left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

harshula commented Jun 27, 2026

Uh oh!

Uh oh!

dougiesquire left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dougiesquire left a comment

Choose a reason for hiding this comment

Uh oh!

harshula commented Aug 5, 2026

Uh oh!

dougiesquire commented Aug 5, 2026

Uh oh!

harshula commented Aug 5, 2026

Uh oh!

dougiesquire left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

harshula commented Jun 16, 2026 •

edited

Loading

aidanheerdegen commented Jun 25, 2026 •

edited

Loading