Make unpinned verify surface missing signer pin - #5
Open
AshSgDe29071999 wants to merge 2 commits into
Open
Conversation
When expected_public_key / --expect-key is omitted, signature verification still proves integrity against the key embedded in the receipt — including an attacker key after rewrite-and-re-sign. Record signer_pin as skipped in the JSON verdict, print a CLI warning, and document the distinction in the README. Fixes AgentPostmortem#3
Author
|
Fixed ruff E501 on the signer_pin assertion in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Without
--expect-key/expected_public_key, a receipt that an attacker rewrote and re-signed with their own key still returnedvalid: truewith nothing inskippedabout provenance. The signature check is correct; the report was not.signer_pininskippedwhen no expected key is supplied--expect-keyis omittedPinned verify behavior is unchanged.
Test plan
pytest(all green)signer_pininskippedsigner_pinas a check, not skippedFixes #3