test: cover non-numeric STT mismatch as medium misheard - #8
Open
AshSgDe29071999 wants to merge 1 commit into
Open
test: cover non-numeric STT mismatch as medium misheard#8AshSgDe29071999 wants to merge 1 commit into
AshSgDe29071999 wants to merge 1 commit into
Conversation
When truth differs but extracted numbers still match, check_misheard takes the medium `misheard` branch rather than high misheard_number. That path had no test; pin it so a future change cannot collapse the two severities. Fixes AgentPostmortem#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_misheardhas two branches: highmisheard_numberwhen digits/number-words differ, and mediummisheardwhen the transcript differs but numbers still match. Only the high path was covered.Case covered
truthwhile number tokens are identical (e.g. “shirt” vs “shoes” around the same “fifteen”)misheardfinding and nomisheard_numberTest plan
pytest -q→ 19 passedFixes #2