Catlab 0.17 / Julia 1.12 compatibility across rewriting, incremental, and schedules - #95
Open
sdwfrost wants to merge 3 commits into
Open
Catlab 0.17 / Julia 1.12 compatibility across rewriting, incremental, and schedules#95sdwfrost wants to merge 3 commits into
sdwfrost wants to merge 3 commits into
Conversation
Recover the ambient category when schedule interpretation callers omit it so AlgebraicABMs schedule evaluation keeps working with current Catlab APIs.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Handle implicit attribute bindings and reconstruct attrtype components directly during pushout-complement checks so attr-aware rewriting still works with Catlab 0.17.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Qualify Base.collect at call sites that became ambiguous under Julia 1.12 now that Catlab also re-exports collect. - Reconstruct attrtype FinDomFunction components in pushout_complement using the raw copaired data when an interface attrvar is unreferenced by any attribute edge. Use the prototype domain shape so the rebuilt component matches Catlab 0.17 ACSetTransformation validation. - Thread Catlab imports through incremental and categorical-algebra modules so the 0.17 layout resolves under explicit using. - Adjust demos and tests to the qualified Base.collect form. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores AlgebraicRewriting.jl compatibility with Catlab 0.17 (and Julia 1.12). The package currently won't load or run its test suite against Catlab 0.17 due to a mix of schedule-interpretation, attr-aware DPO rewriting, and Julia 1.12 name-resolution issues.
Changes
Three logical commits:
fix: infer cat in schedule interpretation— threadinfer_acset_catinto the schedule evaluator so Catlab 0.17'sWithModeldispatch resolves.fix: support attr-aware DPO rewriting in Catlab 0.17— updateRewrite.Utilsfor the new implicit-attr binding semantics introduced in Catlab 0.17 so attribute-carrying rules still rewrite correctly.fix: restore Catlab 0.17 compatibility across rewriting and incremental—Base.collectat the call sites that became ambiguous under Julia 1.12 now that Catlab also re-exportscollect.FinDomFunctioncomponents insidepushout_complementusing the raw copaired data when an interface attrvar is unreferenced by any attribute edge; match the prototype's domain shape so the rebuilt component passes Catlab 0.17ACSetTransformationvalidation.using.Base.collectform.Testing
AlgebraicRewriting.jlfull test suite passes locally against Julia 1.12.5 + Catlab 0.17.5 + the two companion Catlab PRs (AlgebraicJulia/Catlab.jl#999 and AlgebraicJulia/Catlab.jl#1000):Context
Part of a 4-PR stack bringing the AlgebraicJulia downstream stack current on Catlab 0.17:
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com