[pull] master from php:master - #540
Merged
Merged
Conversation
The test suite derives the path to php-fpm from TEST_PHP_EXECUTABLE. This fails on custom build directory layouts, leading to skipping all php-fpm related tests. Users can provide TEST_PHP_FPM_EXECUTABLE for a custom binary path; if this is unset, we'll fall back to TEST_PHP_EXECUTABLE instead.
…ARAM_*()` (#23100) Instead of using a fixed variable name for the temporary, it is now derived from the name of the target variable.
* PHP-8.4: JIT: Preserve parent regs in zend_jit_deoptimizer_start() (#22916)
* PHP-8.5: JIT: Preserve parent regs in zend_jit_deoptimizer_start() (#22916)
…23102) Both functions are declared with no parameters in the stub, but neither implementation called ZEND_PARSE_PARAMETERS_NONE(), so extra positional arguments were silently accepted instead of raising ArgumentCountError. Every other zero-arity function of the same SAPI (apache_request_headers(), apache_response_headers(), getallheaders()) already enforces its arity, and so does the litespeed implementation of apache_get_modules(). No stub or arginfo change is needed. Co-authored-by: lacatoire <ext-lacatoire@cenef.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )