This repository was archived by the owner on Oct 11, 2023. It is now read-only.
Including endpoints in saves for offsets - #30
Open
knordstrom wants to merge 58 commits into
Open
Conversation
added 30 commits
March 7, 2017 17:41
* Changed default namespace to an underscore-separated value
* private[iothubreact] Configuration object => (public) final class * Configuration instance passed as implicit throughout application from IOTHub class, which establishes a default * Added unit test for Configuration changes * new test dependency on mockito
* styling * reducing footprint throughout codebase of implicit config * trait based DI
* Changed default namespace to an underscore-separated value
* private[iothubreact] Configuration object => (public) final class * Configuration instance passed as implicit throughout application from IOTHub class, which establishes a default * Added unit test for Configuration changes * new test dependency on mockito
* styling * reducing footprint throughout codebase of implicit config * trait based DI
* Changed default namespace to an underscore-separated value
* private[iothubreact] Configuration object => (public) final class * Configuration instance passed as implicit throughout application from IOTHub class, which establishes a default * Added unit test for Configuration changes * new test dependency on mockito
* styling * reducing footprint throughout codebase of implicit config * trait based DI
Removing a default in favor of an implicit test declaration
Conflicts: build.sbt src/main/scala/com/microsoft/azure/iot/iothubreact/checkpointing/backends/cassandra/lib/Connection.scala src/main/scala/com/microsoft/azure/iot/iothubreact/javadsl/IoTHub.scala src/main/scala/com/microsoft/azure/iot/iothubreact/scaladsl/IoTHub.scala src/main/scala/com/microsoft/azure/iot/iothubreact/scaladsl/IoTHubPartition.scala src/test/scala/api/API.scala
* CheckpointService config abstracted for usage multiple places * Offset commit sink added * added to integration test, though not yet directly tested in this project
Conflicts: README.md build.sbt samples-java/pom.xml samples-scala/src/main/scala/A_APIUSage/Demo.scala src/main/scala/com/microsoft/azure/iot/iothubreact/MessageToDevice.scala src/main/scala/com/microsoft/azure/iot/iothubreact/checkpointing/Backends/cassandra/lib/Auth.scala src/main/scala/com/microsoft/azure/iot/iothubreact/checkpointing/CPConfiguration.scala src/main/scala/com/microsoft/azure/iot/iothubreact/checkpointing/CheckpointService.scala src/main/scala/com/microsoft/azure/iot/iothubreact/checkpointing/backends/AzureBlob.scala src/main/scala/com/microsoft/azure/iot/iothubreact/checkpointing/backends/CassandraTable.scala src/main/scala/com/microsoft/azure/iot/iothubreact/checkpointing/backends/CheckpointBackend.scala src/main/scala/com/microsoft/azure/iot/iothubreact/checkpointing/backends/cassandra/lib/Connection.scala src/main/scala/com/microsoft/azure/iot/iothubreact/javadsl/IoTHub.scala src/main/scala/com/microsoft/azure/iot/iothubreact/scaladsl/IoTHub.scala src/main/scala/com/microsoft/azure/iot/iothubreact/scaladsl/IoTHubPartition.scala src/main/scala/com/microsoft/azure/iot/iothubreact/sinks/MessageToDeviceSink.scala src/test/scala/api/API.scala
This reverts commit 1b0629e.
* named magic number in scala example app * formatting fix
…s are hashed in the storage backend. Some refactoring and additional DI included to support a test.
Conflicts: CHECKPOINTING.md README.md build.sbt samples-java/src/main/java/DisplayMessagesWithAcknowledgement/Main.java samples-java/src/main/java/SendMessageToDevice/Main.java samples-scala/src/main/scala/A_APIUSage/Demo.scala samples-scala/src/main/scala/E_Checkpoints/Demo.scala samples-scala/src/main/scala/OSN/Demo3_Checkpoints.scala src/main/scala/com/microsoft/azure/iot/iothubreact/SourceOptions.scala src/main/scala/com/microsoft/azure/iot/iothubreact/checkpointing/CheckpointOnPull.scala src/main/scala/com/microsoft/azure/iot/iothubreact/checkpointing/CheckpointService.scala src/main/scala/com/microsoft/azure/iot/iothubreact/checkpointing/OffsetLoader.scala src/main/scala/com/microsoft/azure/iot/iothubreact/checkpointing/backends/cassandra/CheckpointRecord.scala src/main/scala/com/microsoft/azure/iot/iothubreact/config/ConnectConfiguration.scala src/main/scala/com/microsoft/azure/iot/iothubreact/javadsl/IoTHub.scala src/main/scala/com/microsoft/azure/iot/iothubreact/scaladsl/IoTHub.scala src/main/scala/com/microsoft/azure/iot/iothubreact/scaladsl/IoTHubPartition.scala src/test/scala/api/API.scala src/test/scala/com/microsoft/azure/iot/iothubreact/SourceOptionsTest.scala src/test/scala/com/microsoft/azure/iot/iothubreact/checkpointing/OffsetLoaderTest.scala src/test/scala/it/AllIoTDeviceMessagesAreDelivered.scala
Contributor
Author
|
Sorry about the long delay, there were other things that took me away for a bit. It looks to me like this was ready but the hashing we agreed to in the discussion was not implemented. Is that accurate or was there something else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
I marked feature but neither really fit. Technically this is a third category, ie.
Description of the change
Offsets are now saved with a key that includes the IoTHub endpoint so that multiple IoTHubs may be tracked using the same datastore.
Motivation for the change
See discussion here #24
This change is