Fix: Null-guard Calendar onSelect handlers for cleared ranges - #41
Open
sentry[bot] wants to merge 1 commit into
Open
Fix: Null-guard Calendar onSelect handlers for cleared ranges#41sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
✅ Deploy Preview for studenthub-student ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue SH-STUDENT-APP-36, a TypeError occurring when a user clears a date range selection in the Calendar component.
Problem: The
react-day-pickercomponent, when inmode="range", calls itsonSelecthandler withundefinedwhen the user clears or deselects a previously chosen date range. The existing handlers insrc/pages/(dash)/assignment/[id]/page.tsxandsrc/pages/(dash)/work-log/log-date-list/page.tsxunconditionally attempted to access properties likee.fromande.to, leading to aTypeError: undefined is not an object.Solution:
e?.from,e?.to) when accessing properties of thee(date range) object within theonSelecthandlers.loadPagetoif (e && form.formState.isValid)to ensure thatloadPageis only triggered when a valid date range (eis not undefined) is selected, preventing unnecessary page reloads on deselection.Fixes SH-STUDENT-APP-36
Fixes TECH-2216