✨ feat(confession): split ci checks and harden cli scanning - #18
Merged
Conversation
BlackishGreen33
force-pushed
the
codex/ci-cli-acceleration
branch
from
March 9, 2026 17:22
51caca1 to
c472154
Compare
There was a problem hiding this comment.
Pull request overview
This PR restructures CI into parallelized lint/build/test jobs with a preserved quality aggregate gate, and hardens the confession-cli scan flow with stricter flag validation plus proactive cancellation on timeout/SIGINT, backed by new Node node:test coverage.
Changes:
- Split CI into
lint/build/testjobs and add aqualityaggregator gate while keepingcommit-check. - Add root scripts
check:lint,check:build,check:test, and makecheck:cichain them. - Refactor
confession-clito support testable runtime injection, strict flag/enum validation, scan timeout, and SIGINT-triggered cancel; add CLI tests.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds check:* scripts and includes CLI tests in pnpm test. |
| confession-cli/package.json | Adds node --test test script for the CLI package. |
| confession-cli/bin/confession.test.js | New Node node:test suite covering init/list/status/scan success/failure/timeout/SIGINT. |
| confession-cli/bin/confession.js | Adds runtime injection + validation + scan cancel-on-timeout/SIGINT and refactors CLI entry to return exit codes. |
| confession-cli/README.md | Documents stricter validation and scan cancellation behavior. |
| README.md | Updates repo structure, testing matrix, CI commands, and CLI behavior notes. |
| AGENTS.md | Updates repo map and testing/CI guidance to include CLI + split CI jobs. |
| .kiro/steering/testing-standards.md | Updates testing standards to include CLI node:test and coverage expectations. |
| .kiro/steering/tech.md | Updates tech matrix and lists new CI sub-check commands. |
| .kiro/steering/structure.md | Updates structure docs for split CI and CLI test file location. |
| .github/workflows/ci.yml | Implements parallel lint/build/test jobs plus quality gate and workflow concurrency cancellation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
變更摘要\n- 將 CI 拆分為 lint/build/test 並行 job,保留 quality 聚合 gate 與 commit-check\n- 新增 check:lint/check:build/check:test,並讓 check:ci 串接三者\n- 強化 confession CLI:參數驗證、scan 逾時與 SIGINT 主動 cancel、可測試入口\n- 新增 CLI node:test 覆蓋 init/list/status/scan 成功失敗與 cancel 路徑\n- 同步更新 steering、AGENTS、README、CLI README\n\n## 驗證\n- pnpm lint\n- pnpm test\n- pnpm build\n- pnpm check:ci