Fix CI: benchmark startup and SARIF upload permissions - #22
Merged
BlackishGreen33 merged 2 commits intoMar 10, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates CI workflows and related documentation to fix benchmark server startup reliability and prevent SARIF upload failures due to insufficient permissions (especially on forked pull requests).
Changes:
- Update benchmark workflow to start the Next.js server via
pnpm --filter web exec next start ...and print server log tail on health-check timeout. - Update code-scanning workflow permissions and gate
upload-sarifto avoid fork-PR permission failures. - Sync CI policy documentation in
AGENTS.mdand.kiro/steering/tech.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AGENTS.md | Documents required workflow permissions and fork-PR SARIF handling; documents benchmark startup/logging expectations. |
| .kiro/steering/tech.md | Mirrors CI policy updates for code-scanning permissions/gating and benchmark startup/log tail behavior. |
| .github/workflows/code-scanning.yml | Adds actions: read and skips SARIF upload on fork PRs (still uploads artifact). |
| .github/workflows/benchmark-regression.yml | Uses explicit Next.js start command with host/port and tails server logs when health check times out. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BlackishGreen33
deleted the
codex/fix-ci-workflows-permissions-and-startup
branch
March 10, 2026 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm --filter web exec next start -p 3000 -H 127.0.0.1/tmp/confession-web.logtail when health check timeout occurs for faster root-cause debuggingactions: readpermission to code-scanning workflow.kiro/steering/tech.mdandAGENTS.mdwith the CI policy updatesValidation