support sf asset protocol - #76
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds configuration support intended to recognize additional asset-URI protocols (notably Starfall鈥檚 sf) alongside existing asset:// handling.
Changes:
- Fixes
IsAssetURIto usestring.StartsWith. - Introduces
assetURIProtocolsin the default config and merges protocol lists across configs. - Adds a StarfallEx config entry intended to register the
sfprotocol.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lua/cfc_http_restrictions/shared/url.lua | Adjusts asset-URI detection helper (currently still hard-coded to asset://). |
| lua/cfc_http_restrictions/shared/config_loader.lua | Merges assetURIProtocols from additional configs into the base config. |
| lua/cfc_http_restrictions/default_config.lua | Defines default assetURIProtocols list (starts with asset). |
| lua/cfc_http_restrictions/configs/starfallex.lua | Attempts to add sf to asset protocols for StarfallEx. |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.