-
Notifications
You must be signed in to change notification settings - Fork 0
feat: storeReviews 좋아요순 정렬(sort=LIKES) 추가 #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| /** 매장 리뷰 조회 에러 메시지. */ | ||
| export const STORE_REVIEW_ERRORS = { | ||
| INVALID_LIKES_CURSOR: '좋아요순 커서 형식이 올바르지 않습니다.', | ||
| } as const; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When any review's likes change between page requests, this predicate compares every review's live
COUNT(l.id)with a stale boundary and therefore does not prevent duplicates or omissions as claimed. For example, after a first page ends at 9 likes, an unseen 8-like review that rises to 10 is excluded from every subsequent query, while an already-returned 10-like review that drops to 8 is returned again. The cursor must identify a stable ranking snapshot/version, or the API must otherwise account for already-seen rows, to provide mutation-safe pagination.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
의도된 트레이드오프로 유지. 이 커서의 목적은 경계 리뷰의 좋아요 변동으로 인한 인접 페이지 즉시 중복/누락 방지까지이고, 임의 리뷰의 전역 변동까지 막으려면 랭킹 스냅샷·seen-set 커서가 필요해 공개 목록 조회에 과한 비용. 이미 릴리즈된 productReviews의 listProductReviewIdsByLikes와 동일 구현·동일 수용 기준이라 정합성 차원에서도 동일하게 둠.