Clean up baseline persistence and comparison tests - #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
This is the narrowly scoped minor-cleanup pass from the baseline code review. It deliberately does not change optimizer mathematics, hyperparameters, experiment selection policy, notebook code, committed output notebooks, or existing baseline results.
Changes
locals()assignment loop from MNIST resume handling while retaining the explicit truncation logicpaired_terminal_differences, with a backward-compatiblepaired_final_differencespropertyValidation
git diff --checkpython -m compileall -q baseline/rg_baselines baseline/testspython -m unittest discover -s baseline/tests -vpip checkThe temporary workflow used to apply and validate the patch was removed; the PR's net diff contains only the six intended baseline source/test files.
Deferred to the next review
The larger findings remain intentionally untouched: one-head completed-run fingerprint validation, stricter test-holdout policy, convergence censoring, paired one-head contrasts, interruption-equivalence testing, Muon known-answer tests, and the ViT monkeypatch refactor.