[REFACTOR] 문서 목록 조회의 응답 DTO 변환 경계 정리 - #192
Open
poketopa wants to merge 2 commits into
Open
Conversation
poketopa
marked this pull request as ready for review
August 4, 2026 23:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
Closes #191
변경 배경
DocumentService.findAll()만 문서 도메인 엔티티인Page<Document>를 컨트롤러에 반환하고, 컨트롤러에서DocumentListResponse로 변환하고 있었다.프로젝트의 다른 조회 서비스처럼 응답 DTO 변환 책임을 서비스 계층에 두어 도메인 엔티티가 컨트롤러 경계로 노출되지 않도록 정리
변경 내용
GET /document의 기존 페이지 및 문서 응답 계약을 컨트롤러 회귀 테스트로 고정DocumentService.findAll()이Page<DocumentListResponse>를 반환하도록 변경DocumentController에서Document의존과 목록 DTO 변환 제거