Add D&D-style dice notation support to /roll - #317
Merged
Conversation
Agent-Logs-Url: https://github.com/Dans-Plugins/Medieval-Roleplay-Engine/sessions/1850c380-3b03-4a7f-89f8-e170bcbbcb57 Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add D&D-style modifier and multi-roll support to /roll
Add D&D-style dice notation support to /roll
May 3, 2026
There was a problem hiding this comment.
Pull request overview
Extends the /roll (and /dice) command to accept standard D&D-style dice notation (e.g., 2d6, d20+5) instead of only a single max integer, improving TTRPG usability while preserving legacy /roll 20 behavior.
Changes:
- Added dice-notation parsing (via a compiled regex) and multi-die rolling with modifiers.
- Updated the broadcast format to show individual rolls (when applicable) plus modifiers and totals.
- Updated help text and user documentation to describe the new notation and examples.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/main/java/dansplugins/rpsystem/commands/roll/RollCommand.java |
Implements dice-notation parsing, bounded roll execution, and updated broadcast message formatting. |
src/main/java/dansplugins/rpsystem/commands/help/HelpCommand.java |
Updates /roll help line to document dice notation usage. |
USER_GUIDE.md |
Documents supported dice formats and examples for players. |
COMMANDS.md |
Updates command reference with dice notation definition and examples. |
Comment on lines
+89
to
+99
| int sum = 0; | ||
| for (int r : rolls) { | ||
| sum += r; | ||
| } | ||
| int total = sum + modifier; | ||
|
|
||
| String rollsDisplay = buildRollsDisplay(rolls); | ||
| String modDisplay = modifier != 0 ? (modifier > 0 ? " +" + modifier : " " + modifier) : ""; | ||
| String message = medievalRoleplayEngine.colorChecker.getNeutralAlertColor() + "" + ChatColor.ITALIC | ||
| + player.getName() + " rolled " + notation + ": " | ||
| + rollsDisplay + modDisplay + " = " + total; |
Comment on lines
+57
to
+72
| if (m.group(1) != null) { | ||
| // NdM form | ||
| numDice = Integer.parseInt(m.group(1)); | ||
| dieSize = Integer.parseInt(m.group(2)); | ||
| } else if (m.group(3) != null) { | ||
| // dM form (implicit 1 die) | ||
| numDice = 1; | ||
| dieSize = Integer.parseInt(m.group(3)); | ||
| } else { | ||
| // plain number — treat as die size (legacy behaviour) | ||
| numDice = 1; | ||
| dieSize = Integer.parseInt(m.group(4)); | ||
| } | ||
|
|
||
| if (m.group(5) != null) { | ||
| modifier = Integer.parseInt(m.group(5)); |
Member
|
@copilot address comments |
…ent overflow Agent-Logs-Url: https://github.com/Dans-Plugins/Medieval-Roleplay-Engine/sessions/a190ae5f-b9f4-4131-9d98-cffb87ff4fcc Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Contributor
Author
Both issues addressed in ace163e:
|
Member
|
@copilot I created a snapshot release using this branch, causing the CI to build a JAR. This is from a user testing that JAR: Please resolve |
Agent-Logs-Url: https://github.com/Dans-Plugins/Medieval-Roleplay-Engine/sessions/a26eec07-1f65-4024-8eac-48dcd1bad694 Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Contributor
Author
Fixed in c0fa01c. The root cause is that the roll message was only delivered through the proximity-based local-chat system ( The fix splits delivery into two paths:
Regarding "file says 14": the JAR was correctly built from this branch. The version Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/main/java/dansplugins/rpsystem/commands/roll/RollCommand.java:75
- The parser currently accepts legacy numeric input with a modifier (e.g.
20+5) because the regex allows an optional[+-]\d+after the plain-number branch. That format isn’t standard dice notation and isn’t documented in COMMANDS.md/USER_GUIDE.md, so it’s likely to confuse users. Consider rejecting modifiers when the legacy numeric form is used (and required20+5instead), or document it explicitly.
if (m.group(5) != null) {
modifier = Integer.parseInt(m.group(5));
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RollCommand.javato parse full dice notation (NdM,dM,NdM+K,NdM-K, plain number legacy form)java.util.Randominstead ofMath.random()for better randomnessMAX_DICE=100,MAX_DIE_SIZE=10000) to prevent abuseInteger.parseIntcalls in try/catch to return friendly error on oversized inputs (e.g.999999999999d6)MAX_MODIFIER=10000bound to prevent integer overflow in total calculationplayer.sendMessage()so the roller never sees a blank response; nearby players receive the message viasendRPMessageToPlayersWithinDistanceExcludingTargetHelpCommand.javaCOMMANDS.mddocumentationUSER_GUIDE.mddocumentation