Fix command bugs and remove stray file - #183
Merged
Merged
Conversation
- /mr get no longer throws an uncaught NumberFormatException on a non-numeric amount; it now shows the usage message - /mr list now checks morerecipes.listitems (matching plugin.yml and the docs) instead of the undeclared morerecipes.list - Remove a stray, unreferenced empty "master" file at the repo root Closes #180, #181, #182 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Companion commit to f88aaa8 — the prior commit's git add included an invalid "master" pathspec that aborted before staging these files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric:
Repo-specific:
One note for reviewers: This comment was drafted during a Gardener session (Stephenson-Software/gardener). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/mr getno longer throws an uncaughtNumberFormatExceptionwhen given a non-numeric amount (e.g./mr get Saddle abc); it now shows the usage message instead of a generic internal-error message./mr listnow checks themorerecipes.listitemspermission, matchingplugin.yml,COMMANDS.md, andUSER_GUIDE.md— previously it checked the undeclaredmorerecipes.list, which could deny the command to non-op players despite the docs promising it's available by default.masterfile that had accidentally been committed at the repo root.GetCommandfix.Test plan
mvn compile— clean buildmvn test— newGetCommandTestpasses (2/2)GetCommandfix reverted (git stash),execute_withNonNumericAmount_returnsFalseWithoutLookingUpItemfails with the uncaughtNumberFormatException; with the fix restored, it passes.RecipeRegistry.java→objects/*.java) have valid 3x3 shapes and matching ingredient keys — no drift found.COMMANDS.md,USER_GUIDE.md,CONFIG.md,CHANGELOG.mdagainst the implementation.Closes #180
Closes #181
Closes #182
This PR description was drafted during a Gardener session (Stephenson-Software/gardener).