Rename internal constants from dunders, return MappingProxyType from functions - #122
Merged
Conversation
…e reserved for CPython. This doesn't change the __prefab_pre_init__, __prefab_init__ or __prefab_post_init__ functions as they may be used or defined by users directly.
…s`. Make all of the `get_x` functions return `MappingProxyType` to indicate they are not to be modified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal details are renamed from
__classbuilder_*__to_classbuilder_*_as dunder names are technically reserved for CPython__prefab_post_init__or similar values as those are defined by the user and as such this would break usageget_fields,get_flags,get_methodsandget_attributesnow all returnMappingProxyType. These are intended as views, the user should not mutate them but the original class still owns them.