Skip to content

feat(i18n): Add the missing translation keys - #139

Open
nageih wants to merge 2 commits into
EnigmaticaModpacks:developfrom
nageih:chs
Open

feat(i18n): Add the missing translation keys#139
nageih wants to merge 2 commits into
EnigmaticaModpacks:developfrom
nageih:chs

Conversation

@nageih

@nageih nageih commented May 4, 2026

Copy link
Copy Markdown
Contributor

Haha, sorry for posting two PRs in such quick succession, but I just discovered a new issue. It’s not something I can easily fix on my own, so I need to discuss it with you. Here, as well as elsewhere, we’ve found texts—but unlike ordinary lore or tooltips registered in other ways, this is flavor_text or hidden_text.

After looking into it, I discovered that this item component is registered by the Ars Nouveau mod. To make matters worse, this item component does not support translation keys, which means it’s difficult for us to localize it. Here is the mod’s source code I referenced: https://github.com/baileyholl/Ars-Nouveau/blob/48674342c0bd4999c7b99ebbd5922bdebf67d91b/src/main/java/com/hollingsworth/arsnouveau/api/spell/AbstractCaster.java#L388

What I’d like to discuss with you is how best to handle these texts. I think they should be translated, so we may need to register this tooltip using a different method, or find another solution. It’s up to you, so we need to talk it over.

@MuteTiefling

Copy link
Copy Markdown
Contributor

Hey, no worries.

The hidden_text doesn't need to be translated. That's just creating this unreadable script here:
image
It is supposed to be nonsense.

Ultimately, I think the best option would be to PR a change to Ars Nouveau to allow that field to support translatable text. They're generally open to PRs. Would you be willing to work with them on it?

Otherwise, from my side I think the only thing I could do would be to remove the flavor_text and replace it with lore instead. That moves the text's placement, however, and would be inconsistent with other Caster Tomes provided by Ars Nouveau.

@nageih

nageih commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

Actually, I agree with you. I think submitting a PR to the original mod is probably the best approach, but it could take a long time, and there’s no guarantee it will be merged.
Even so, I really do think this is the best approach. Maybe I could start by submitting a pull request to the original mod, and if the original mod author doesn’t respond, then try removing flavor_text? I don’t think it has to be lore-specific; we could use standard Kubejs methods to add tooltips, and I think that should allow us to control the number of lines added.
I’m not an expert in Kubejs—my knowledge is limited to translation—so this approach will mainly require your help. Thanks for your hard work.

@MuteTiefling

Copy link
Copy Markdown
Contributor

Let's start with that then, work with the Ars Nouveau team to see if this can be adjusted to accept translations. They're a good bunch and are generally open to this type of request.

@nageih nageih changed the title feat(i18n): Add the missing translation keys. feat(i18n): Add the missing translation keys May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants