Skip to content

Add printing device tracing records for non-target callbacks #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thyre merged 7 commits into from
Mar 16, 2026
Merged

Add printing device tracing records for non-target callbacks #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
072dc46
Tool: Refactor enabling device tracing records
Thyre Mar 9, 2026
cd7aaad
Tool: Register available record callbacks
Thyre Mar 9, 2026
4c7b776
Tool: Return early from buffer_complete callback
Thyre Mar 9, 2026
09d7fb9
Tool: Add device tracing records for host events
Thyre Mar 9, 2026
3abfd06
Tool: Refactor target records into own functions
Thyre Mar 10, 2026
550167f
Tool: Make record print functions static
Thyre Mar 10, 2026
63af040
Add feature check for wstype and guard other events
Thyre Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion cmake/OMPTChecks.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,21 @@

include( CheckIncludeFile )
include( CheckTypeSize )
include( CheckCXXSourceCompiles )

function( OMPT_HEADER_CHECK )

check_include_file( "omp-tools.h" HAVE_OMP_TOOLS_HEADER )
if( HAVE_OMP_TOOLS_HEADER )
set( CMAKE_EXTRA_INCLUDE_FILES "omp-tools.h" )
set( CMAKE_EXTRA_INCLUDE_FILES "omp-tools.h" )
# OpenMP 5.1 checks
# Check for added callback values
check_type_size( ompt_callback_target_emi OMPT_CALLBACK_TARGET_EMI LANGUAGE C )
check_type_size( ompt_callback_target_data_op_emi OMPT_CALLBACK_TARGET_DATA_OP_EMI LANGUAGE C )
check_type_size( ompt_callback_target_submit_emi OMPT_CALLBACK_TARGET_SUBMIT_EMI LANGUAGE C )
check_type_size( ompt_callback_target_map_emi OMPT_CALLBACK_TARGET_MAP_EMI LANGUAGE C )
check_type_size( ompt_callback_masked OMPT_CALLBACK_MASKED LANGUAGE C )
check_type_size( ompt_callback_error OMPT_CALLBACK_ERROR LANGUAGE C )
# Check for new enum values
# New fields in ompt_scope_endpoint_t
check_type_size( ompt_scope_beginend OMPT_SCOPE_BEGINEND LANGUAGE C )
Expand Down Expand Up @@ -130,11 +132,29 @@ function( OMPT_HEADER_CHECK )
check_type_size( ompt_record_target_data_op_t OMPT_RECORD_TARGET_DATA_OP LANGUAGE C )
check_type_size( ompt_record_target_map_t OMPT_RECORD_TARGET_MAP LANGUAGE C )
check_type_size( ompt_record_target_kernel_t OMPT_RECORD_TARGET_KERNEL LANGUAGE C )

# Check for more niche cases

# ompt_record_work_t uses wstype in OpenMP v5.0, work_type in OpenMP v5.1 and newer.
check_cxx_source_compiles( [[
#include <omp-tools.h>
int main( int argc, char** argv )
{
ompt_record_work_t work;
return work.wstype;
}
]] HAVE_OMPT_RECORD_WORK_WSTYPE )
if( NOT HAVE_OMPT_RECORD_WORK_WSTYPE )
set( HAVE_OMPT_RECORD_WORK_WSTYPE FALSE PARENT_SCOPE )
else()
set( HAVE_OMPT_RECORD_WORK_WSTYPE TRUE PARENT_SCOPE )
endif()
set( CMAKE_EXTRA_INCLUDE_FILES )
endif()

endfunction()


set( COMPILER_TOOLCHAIN GCC CACHE STRING "Set compiler toolchain. Will overwrite native CMake commands" )
function( OMPT_ADDITIONAL_CFLAGS )

Expand Down
4 changes: 3 additions & 1 deletion src/tool-definitions.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

#define FALSE 0
#define TRUE 1
#define HAVE( X ) defined( HAVE_ ##X ) && HAVE_ ##X == TRUE
#define HAVE( X ) defined( HAVE_ ##X ) && ( HAVE_ ##X == TRUE )

/* OpenMP 5.1 */
#define HAVE_OMPT_CALLBACK_TARGET_EMI @HAVE_OMPT_CALLBACK_TARGET_EMI@
Expand Down Expand Up @@ -108,4 +108,6 @@
#define HAVE_OMPT_RECORD_TARGET_MAP @HAVE_OMPT_RECORD_TARGET_MAP@
#define HAVE_OMPT_RECORD_TARGET_KERNEL @HAVE_OMPT_RECORD_TARGET_KERNEL@

#define HAVE_OMPT_RECORD_WORK_WSTYPE @HAVE_OMPT_RECORD_WORK_WSTYPE@

#endif /* PRINTF_TOOL_DEFINITIONS_H */
Loading
Loading