fix: Wrong resulting data length that sending after extra BasePacketLayer modification - #1064
Open
am1goo wants to merge 1 commit into
Conversation
…BasePacketLayer modification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
If any extra
BasePacketLayeris in use and it change the resulting size of packet (in bytes) like "packet padding" technique, the final value of data length still equalspacket.Sizebefore any modifications.Here the existing code of
SendBroadcastmethod:Expected behavior:
The resulting size of data to send must equals the calculated data length from extra
BasePacketLayer.Here what it should be:
More info at: #1063