Add some unit tests - #782
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdded Catch2 tests for ChangesNode tests
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #782 +/- ##
==========================================
- Coverage 83.90% 83.84% -0.06%
==========================================
Files 172 172
Lines 7231 7231
Branches 850 850
==========================================
- Hits 6067 6063 -4
- Misses 883 885 +2
- Partials 281 283 +2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Move the multi-input join coverage from `transform_node` tests to a dedicated `multilayer_join_node` test by renaming `join_test.cpp` to `multilayer_join_test.cpp`, updating the test case name, and adjusting the test wiring. Remove the old join test from `test/transform_node_test.cpp` and update `test/CMakeLists.txt`.
|
@phlexbot format |
Format Fixes Applied✅ clang-format fixes pushed (commit ffcf083) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/multilayer_join_test.cpp`:
- Around line 35-39: Remove the unused selector template helper from the test
fixture, including its product_selector construction logic, since it has no call
sites in the file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 613f70a4-b1d0-44f2-8744-9d76a4340de4
📒 Files selected for processing (3)
test/CMakeLists.txttest/multilayer_join_test.cpptest/transform_node_test.cpp
📜 Review details
⏰ Context from checks skipped due to timeout. (5)
- GitHub Check: Analyze actions with CodeQL
- GitHub Check: Analyze cpp with CodeQL
- GitHub Check: build (gcc, none)
- GitHub Check: coverage
- GitHub Check: clang-tidy-check
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{cpp,cc,cxx,h,hpp}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{cpp,cc,cxx,h,hpp}: Use clang-format tool for all C++ code formatting (VS Code auto-formats on save); configuration defined in.clang-formatwith 100-character line limit and 2-space indentation
Follow clang-tidy recommendations defined in.clang-tidy
Files:
test/transform_node_test.cpptest/multilayer_join_test.cpp
**/*.{hpp,cpp}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{hpp,cpp}: Use.hppfor header files,.cppfor implementation, and*_test.cppfor test files in C++
Enforce 100-character line limit and 2-space indentation in C++ code via.clang-format
UseQualifierAlignment: Right(east-const) style:int const xnotconst int xin C++
UsePointerAlignment: Leftin C++ (pointer*attached to type, not variable name)
All C++ identifiers must uselower_casenaming: namespaces, classes, structs, enums, functions, variables, parameters, members, and constants
Exception to C++ naming: template parameters useCamelCase
Exception to C++ naming: macros useUPPER_CASE
Private, protected, and constant members in C++ must have a trailing underscore (_), no trailing underscore on anything else
Useenum classpreferred over plainenumin C++
Usestd::shared_ptrfor shared ownership,std::unique_ptrfor exclusive ownership, raw pointers for non-owning references only in C++
Use functors with agent-noun pattern:ModelEvaluator evaluate_model(...)in C++
Apply.clang-tidychecks for bugprone, cert, clang-analyzer, concurrency, cppcoreguidelines, misc, modernize, performance, portability, and readability as defined in the.clang-tidyconfiguration file
Usephlex::namespace for core code,phlex::experimental::for experimental features in C++
Files:
test/transform_node_test.cpptest/multilayer_join_test.cpp
🪛 Cppcheck (2.21.0)
test/multilayer_join_test.cpp
[style] 36-36: The function 'selector' is never used.
(unusedFunction)
🔇 Additional comments (3)
test/transform_node_test.cpp (1)
1-153: LGTM!test/CMakeLists.txt (1)
212-227: LGTM!test/multilayer_join_test.cpp (1)
1-34: LGTM!Also applies to: 41-105
2 participants
This adds two new tests.
One is a unit test for the
transform_node.The other is a test (it is not clear to me that it is a unit test) for the infrastructure that does the join for a the kind of transform_node that combines two products from different data layers.
Tests
transform_nodeunit tests for single-output transforms and multi-output product storage.multilayer_join_node<2>coverage for joining products from separate data layers.Build system
transform_node_test.cppandmultilayer_join_test.cppintest/CMakeLists.txt.phlex::core_internal.Code quality