ci: make public-hygiene-lint green - #2
Merged
Conversation
added 2 commits
August 8, 2026 16:00
The public-hygiene gate flags text in customer-readable files that describes how the software was BUILT rather than what it DOES. Every hit in this repo is rewritten to state the behaviour or the invariant; no allow markers are added, so the gate keeps its teeth.
busbar 1.5.3 retired two config surfaces this fixture still used: `auth.methods:`
and INLINE module entries under `auth.admin_auth:`. An identity provider is now
defined ONCE under `identity-providers:` -- `browser_login` and `settings`
hanging off that single definition -- and referenced elsewhere by bare name.
A config still carrying the old shape is not merely deprecated: core recognises
it as a 1.x config and refuses to start, so the fixture described a gateway that
could never come up. All the test could report was the symptom, a long way from
the cause:
test github_*_flow ... FAILED
panicked at tests/e2e.rs: busbar exited early during health poll: exit status: 1
Reproduced by rendering this fixture's own YAML and feeding it to a `busbar`
built from the core branch CI tests against:
[error] config.yaml: this looks like a busbar 1.x config; run
`busbar --migrate-config <config.yaml>` and review the flagged items.
1.x markers found:
- `auth.methods:` (retired 1.5.3 -> the matching `identity-providers:`
definition (browser_login + settings are per-provider))
- `auth.admin_auth:` carries INLINE module entries (retired 1.5.3 -> define
the provider once under `identity-providers:` and reference it by bare name)
The replacement shape is core's own `--migrate-config` output for the previous
fixture, confirmed by re-validating: the 1.x gate is cleared and the only
remaining complaint is that the github plugin is not in the plugins directory,
which is precisely what this test puts there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
public-hygiene-lint was RED on
mainin this repo. Every hit is fixed by rewriting the text tostate the BEHAVIOUR rather than our internal process. No allow markers were added anywhere in
this change: a blanket allow would turn the gate into decoration.
Hits found on
main, and the decision for each.github/scripts/next-version.sh+.github/workflows/release-selftest.yml[internal-issue-id]cited an internal guard id. REWRITTEN: the sentences already state what the self-test does, so
the id is simply dropped. These were the only two hits in this repo.
Red before green
Same invocation CI uses. Output is ASCII-folded for this description; the runs are verbatim
otherwise.
Before (on
main)After (this branch)